Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Joomla radio buttons style to JEM settings radio buttons #1866

Closed
Heklaterriol opened this issue Nov 27, 2024 · 4 comments
Closed

Adapt Joomla radio buttons style to JEM settings radio buttons #1866

Heklaterriol opened this issue Nov 27, 2024 · 4 comments
Labels
enhancement New feature or request fixed Have a commit with the solution.

Comments

@Heklaterriol
Copy link
Contributor

When working on #1861 I noticed, that the JEM setting readiobutton styling is very wide and not like in the Joomla settings.

So I propose to switch them to the Joomla styling:

JEM style:
settings previous

Joomla style:
settings new

There is one minro point: when set to "No" or "Hide" the button is just grey and not red

Any objections to adjusting it to the Joomla settings style?

@Heklaterriol Heklaterriol added the enhancement New feature or request label Nov 27, 2024
@jojo12
Copy link
Contributor

jojo12 commented Nov 27, 2024

I agree to the Joomla settings style!

@mckillo
Copy link
Collaborator

mckillo commented Nov 27, 2024

I agree too.

@Heklaterriol
Copy link
Contributor Author

After some experiments I have a new suggestion: just make the buttons smaller:
radio-buttons

@jojo12
Copy link
Contributor

jojo12 commented Nov 29, 2024

I like it, well done!

@jojo12 jojo12 added the fixed Have a commit with the solution. label Nov 29, 2024
Heklaterriol added a commit that referenced this issue Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Have a commit with the solution.
Projects
None yet
Development

No branches or pull requests

3 participants