warning in category-calendar after the fix for category - archive

[jojo12]

(Tested in Responsive) , I get:
Warning: Undefined variable $archive_link in /home/folktanz/public_html/components/com_jem/views/category/view.html.php on line 150

[mckillo]

Check it, it should be solve it.

[mckillo]

Sorry, forget to upload some lines... check the last commit.

[jojo12]

Now there is no more the archived events in the calendar, even with setting "show archived events =yes"
EDIT: it seems this was never working in calendar category, but is prepared with the setting.

[mckillo]

Do you have tested the last commit a87b166?

[jojo12]

Yes, and retried with cache cleaning before, doesn't show archived events in category calendar.

oops and retried category-archive in responsive: shows now venue_archive!!!

[mckillo]

Sorry, call other route. See the last commit.

[jojo12]

category - archive is back, thanks,
but category - calendar doesn't show archived events in calendar!

[mckillo]

No calendars have an archive icon (top right corner). In the code, there is no code about it.
This is for dev (new feature for calendars).
You can see the archive events in the calendar, if you set 'Show archived events' in the menu setting.

[jojo12]

this is not true: at least the general calendar has this and the option is in menu settings!
I don't mean archive button, but archived events are shown in calendar!

[jojo12]

You can see the archive events in the calendar, if you set 'Show archived events' in the menu setting.

No, event when this setting is yes, you can't see archived events in the category - calendar-

It is possible, that this was made only in calendar and not in category - calendar. (even if the setting is in the menu)

[mckillo]

Sorry but I don't agree, this option in menu setting was dev by me months ago. JEM hasn't haved the archive icon in the top-right for the calendar views. There isn't $archive_link in the code of these views.

[jojo12]

I think there is a misunderstanding: there are two different things:

1. archive button top right with link to archive
2. menue setting to show archived events in calendar

The calendar views don't need (absolutely NOT) an archive button top right!
The general JEM calendar (menue) shows archived events when "show archived events=yes"
(I am not sure, but it could be a new feature, to show archived events in the other calendars too (venue calendar, category calendar, week calendar). It seems, this is prepared, because there is a menue setting "show archived events=" too.

But I would wait to add this

[jojo12]

So I would say, the warning is away. The problem is solved.