Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the icons in the sorting menu (eventlist view) #1876

Closed
mckillo opened this issue Dec 25, 2024 · 14 comments
Closed

Hide the icons in the sorting menu (eventlist view) #1876

mckillo opened this issue Dec 25, 2024 · 14 comments
Labels
enhancement New feature or request fixed Have a commit with the solution.
Milestone

Comments

@mckillo
Copy link
Collaborator

mckillo commented Dec 25, 2024

New option menu in the eventlist view to hide the icon in the sorting menu.

image

@mckillo mckillo added the enhancement New feature or request label Dec 25, 2024
mckillo added a commit that referenced this issue Dec 25, 2024
New option menu in the eventlist view to hide the icon in the sorting menu.
@mckillo
Copy link
Collaborator Author

mckillo commented Dec 25, 2024

Now in Legacy layout, the event list view shows the icon too, when this new options is YES.

image

See last commit

mckillo added a commit that referenced this issue Dec 25, 2024
@mckillo mckillo added the fixed Have a commit with the solution. label Dec 25, 2024
@mckillo
Copy link
Collaborator Author

mckillo commented Dec 25, 2024

Add new options for the icons in title and event data

image

And the event list view when all options are NO

image

mckillo added a commit that referenced this issue Dec 25, 2024
…1876

New options menu in the eventlist view to hide the icon in the event title and event data.
mckillo added a commit that referenced this issue Dec 25, 2024
…1876

New options menu in the eventlist view to hide the icon in the event title and event data.
@jojo12
Copy link
Contributor

jojo12 commented Dec 25, 2024

This is only for legacy!?

@mckillo
Copy link
Collaborator Author

mckillo commented Dec 25, 2024

For responsive too

@jojo12
Copy link
Contributor

jojo12 commented Dec 25, 2024

I tried the menue setting is there but no changes in the view.

@mckillo
Copy link
Collaborator Author

mckillo commented Dec 26, 2024

This new feature is all changes of this branch.

@jojo12
Copy link
Contributor

jojo12 commented Dec 26, 2024

Aah, I know now: we forgot that responsive has 2 different layouts: default_jem_eventlist.php and default_jem_eventlist_small.php!
and you only adapted the one (default_jem_eventlist.php =modern look).
The tablelike look (default_jem_eventlist_small.php should be adapted too!
EDIT: I had to correct this!

@Heklaterriol
Copy link
Contributor

cool, thank you!

@mckillo
Copy link
Collaborator Author

mckillo commented Dec 27, 2024

Yes, I can update it too, I'll try to find a time windows to do it.

@jojo12
Copy link
Contributor

jojo12 commented Dec 27, 2024

So you forgot it or you decided, that this will not be needed? We can discuss!

@mckillo
Copy link
Collaborator Author

mckillo commented Dec 27, 2024

Here you are, I haven't test it, please if you can.
If you want this commit 49a0514 has the indexed lines for this file.

@jojo12
Copy link
Contributor

jojo12 commented Dec 27, 2024

It seems, that there are some "else" , when there is no e.g. county, so it writes "-", but with the icon!
grafik

@jojo12 jojo12 removed the fixed Have a commit with the solution. label Dec 27, 2024
mckillo added a commit that referenced this issue Dec 29, 2024
@mckillo
Copy link
Collaborator Author

mckillo commented Dec 29, 2024

Solved, when the layout has defined a % in the table, use the small layout.

With Show Icons in event data = NO:

image

With Show Icons in event data = YES:

image

@mckillo mckillo added the fixed Have a commit with the solution. label Dec 29, 2024
@mckillo mckillo added this to the JEM 4.4.0 milestone Dec 29, 2024
@jojo12
Copy link
Contributor

jojo12 commented Dec 29, 2024

fine, can be closed

@jojo12 jojo12 closed this as completed Dec 29, 2024
@mckillo mckillo modified the milestones: JEM 4.4.0, JEM 4.3.2 Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Have a commit with the solution.
Projects
None yet
Development

No branches or pull requests

3 participants