Bug: General JEM setting>User Control>Registration>Allow event Registration

[jojo12]

Perhaps the following error is just older and only detected now! Sorry from my part.

The event registration in general JEM settings in Backend has 3 options: No, Yes and Allow Event Registration.

If I choose there "Yes", then the frontend edit shows only a yes which can't be changed "Yes".
When I create an event in frontend, there is (in the view) only the title "Registration" and a subtitle "Description". This is wrong!

If I create an event in backend, I have a box with the 3 possibilities and "Yes" is chosen.
In the view the "Registration"-part is full there, as it should be!

I see, the settings in backend and frontend are not congruent (=synchronised), this means on backend it can be "No" and on frontend it can be "Yes"

[mckillo]

Test it. Now you can register for the event if the JEM setting is set to 'yes'.

[jojo12]

it works, thanks
important to know: if general JEM setting is set to yes, then backend event setting shows the possibility to "limited", but this is only possible if in general JEM setting "use event setting" is choosen.
In frontend you only see this possibility, if JEM general setting is "use event setting"

[jojo12]

I tested more and I am not yet satisfied, sorry.
I made the following test (to reproduce):
The general JEM setting is NO, I change to YES and save and clean the cache
I open new event in backend, there is a dropdown field: where I can choose: NO, YES or LIMITED,
But the visible setting is NO as defautl!
I can change, but it should be YES as default because the general JEM says YES.
It's good that I can change to NO or to LIMITED.

In Frontend edit, there is no dropdown field, there is only YES. and I can't choose or NO or LIMITED.
It would be good to choose.

When the general JEM setting is USE EVENT SETTINGS, then frontend and backend is ok.

[mckillo]

OK, this was set up in the previous design, but it can be modified (coming soon).

[mckillo]

Here you are. Now the registration option displays YES, NO, and LIMITED in the event edit view (Frontend), for both responsive and legacy layouts. Check it.

[jojo12]

1. BUT the only thing which rests: when JEM general =YES and you change in Backend or Frontend to NO, then there is in event view something visible
   

If I see right, then "Description" is title of Venue Description --> nonsense

EDIT: the solution is easy: delete the line echo Text::_('COM_JEM_VENUE_DESCRIPTION');
AND move the <h2 class="register"><?php echo Text::_('COM_JEM_REGISTRATION'); ?></h2>
into the case 1 and case 2

[jojo12]

2. When JEM general =NO, then you can change in Frontend editevent to YES.
   This should not be: if the administrator decides to disable event registration, this decision must be fix! NO can't be changed in FE!
   The only decision event creator should be able to do, is: YES or LIMITED
   (Because in Backend there are only admins, there is not the problem!)

[mckillo]

Now I think I understand everything. Please check it, and I hope to resolve everything.

[jojo12]

Excellent! Sorry, sometimes my trials to explain are very complicated. Thank you for understanding!

The only thing, you forgot to adapt is the legacy view: the views/event/tmpl/default.php

EDIT: After that this can be closed.

[mckillo]

Here you are the update in the legacy view.

[jojo12]

thanks, This will be closed! Ready for 4.3.2