Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3.2 b: JEM general settings>venue page>Show weblink to venue doesn't make sense, can be omitted #1884

Closed
jojo12 opened this issue Jan 13, 2025 · 4 comments

Comments

@jojo12
Copy link
Contributor

jojo12 commented Jan 13, 2025

(only on venue page! On event page this is intended and make sense!)

Show weblink to venue has 3 options: no link, link to venue URL and link to venue detail view.

Because we are just on the venue detail page, it has no sense, to link to the venue details view!
The link to venue URL is given with the column venue URL which is linked. There is no need to an additional link! AND there is no other link on venue title!

So this can issue (button) can be omitted! global_show_detlinkvenue

@jojo12 jojo12 added bug Something isn't working change testing needed labels Jan 13, 2025
@mckillo
Copy link
Collaborator

mckillo commented Jan 13, 2025

But this global_show_detlinkvenue option is used in the venue view to show the url of venue (website link).

mckillo added a commit that referenced this issue Jan 13, 2025
Add missing string.
Move the venue settings inside the globalattribs fieldset, so they will be correctly stored in the jm_config table.
Remove some comments.
@mckillo
Copy link
Collaborator

mckillo commented Jan 13, 2025

This commit doesn't address your issue, but if it's related to JEM settings, I only fixed some detected bugs.

  • Add missing string.
  • Move the venue settings inside the globalattribs fieldset, so they will be correctly stored in the jem_config table (important)
  • Remove some comments (minor detail)

mckillo added a commit that referenced this issue Jan 13, 2025
Add missing string.
Move the venue settings inside the globalattribs fieldset, so they will be correctly stored in the jm_config table.
Remove some comments.
@jojo12 jojo12 removed bug Something isn't working change testing needed labels Jan 13, 2025
@jojo12
Copy link
Contributor Author

jojo12 commented Jan 13, 2025

can be closed

@jojo12
Copy link
Contributor Author

jojo12 commented Jan 20, 2025

@Heklaterriol: well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants