Bug: no time in jem_wide module from 4.3.1+

[jojo12]

post from king louis in forum:
in JEM 4.3.1+ there is only the date, but no time! He says, this was earlier.
I reproduced this on 4.3.1 and 4.3.2b2. This bug is only in responsive style!
This should be solved before release of 4.3.2

[mckillo]

The time is in the title of the date. If you move your mouse over the date, you will see a tooltip with the date and time.
This is the design of this module, in \modules\mod_jem_wide\tmpl\responsive\default_jem_eventslist.php Line119-122:

<div class="jem-event-info time" title="<?php echo Text::_('COM_JEM_TABLE_DATE').': '.strip_tags($item->dateinfo); ?>">
    <?php echo $item->date;
    echo $item->dateschema; ?>
</div>

Now, do we change it?

[mckillo]

This code was added in Commit 51dbd04 by Egnarts94 on Aug 1, 2018

[mckillo]

In legacy, there is a conditional to show the time:

<span class="date" title="<?php echo strip_tags($item->dateinfo); ?>"><?php echo $item->date; ?></span>
<?php if ($item->time && $params->get('datemethod', 1) == 1) : ?>
     <span class="time" title="<?php echo strip_tags($item->dateinfo); ?>"><?php echo $item->time; ?></span>
<?php endif; ?>

Solution: I can add this code of time to the responsive layout. Do you agree?

[mckillo]

I have found the error in the code...after 7 years is solved :-) see next commit

[mckillo]

The JEM wide module must have this setting:

Now, the module view also displays the time.

[jojo12]

excellent! Now we need to brake: if not our code will be perfect. And I don't like perfection! ;-)

[jojo12]

we can close!

[mckillo]

Thanks. Nothing is perfect, and chasing perfection is a waste of time; it never ends. You have to be practical.