Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates the full context when 'Read More' is used #1896

Closed
mckillo opened this issue Feb 2, 2025 · 10 comments
Closed

Duplicates the full context when 'Read More' is used #1896

mckillo opened this issue Feb 2, 2025 · 10 comments
Labels
fixed Have a commit with the solution.
Milestone

Comments

@mckillo
Copy link
Collaborator

mckillo commented Feb 2, 2025

Image

@mckillo mckillo added bug Something isn't working releaseblocker and removed bug Something isn't working releaseblocker labels Feb 2, 2025
@mckillo
Copy link
Collaborator Author

mckillo commented Feb 2, 2025

Sorry, I can't reproduce this error again.

@mckillo mckillo closed this as completed Feb 2, 2025
@mckillo mckillo reopened this Feb 12, 2025
@jojo12
Copy link
Contributor

jojo12 commented Feb 12, 2025

has this to do with #1706 ?

@mckillo
Copy link
Collaborator Author

mckillo commented Feb 12, 2025

Yes, this issue can have the same source that other. I have to research it.

@jojo12
Copy link
Contributor

jojo12 commented Feb 12, 2025

for understanding:

Trying to understand the general JEM settings "readmore" and "introtext". They are not programmed at the end!

In the JEM modules we have "readmore" settings too, which work well and make sense. But they work otherwise:
Because a Module has not enough place, there is a setting how many caracters should be shown. It shows only these.
With "readmore" you are linked into the event detail view with the whole text. This works fine.

The general JEM settings with YES for "introtext" and "readmore" wants to show only a "public" introtext in the event detail view. Then should come a button to login as "registered" or more, after that the registered can view the whole text.

There is also a "introtext" in the menue settings: this is something different!

I think (until now) there's no need for having a hidden and a visible part of event details. If you want you can change an event from public to registered, then it is only visible for registered users.

@jojo12
Copy link
Contributor

jojo12 commented Feb 12, 2025

when I open the eventdescription and insert the button readmore and save,
the green infotext says: "Folgende Felder des Events wurden erfolgreich aktualisert: introtext [ID:393]"
and there is an other infotext: "Der Eintrag wurde gespeichert."
then the text after the readmore button is doubled inclusive the readmore button

@jojo12
Copy link
Contributor

jojo12 commented Feb 12, 2025

Good to know: this problem doesn't exist in venuedescription.
after inserting readmore and saving the green infotext says "Der Eintrag wurde gespeichert."

@jojo12
Copy link
Contributor

jojo12 commented Feb 12, 2025

No, issue #1706 has nothing to do with doubeling the description after inserting "readmore"
I propose to hide readmore and introtext in general JEM settings! with <!--

@mckillo
Copy link
Collaborator Author

mckillo commented Feb 12, 2025

I know, but origin is the same, when I use the 'read more'. I'm debugging it.

mckillo added a commit that referenced this issue Feb 12, 2025
When the event editor uses the 'Read More' feature, the introtext and fulltext are saved correctly.
@mckillo
Copy link
Collaborator Author

mckillo commented Feb 12, 2025

This commit fixs the issue. Now, when the event editor uses the 'Read More' feature, the introtext and fulltext are saved correctly.

@mckillo mckillo added the fixed Have a commit with the solution. label Feb 12, 2025
@mckillo mckillo added this to the JEM 4.3.3 milestone Feb 12, 2025
@jojo12
Copy link
Contributor

jojo12 commented Feb 13, 2025

welldone! can be closed

@jojo12 jojo12 closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Have a commit with the solution.
Projects
None yet
Development

No branches or pull requests

2 participants