feature: make it works without submodules #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format cmake files and sources
make format again
make format again
make format again
cleanup cmake files
make example useable to test installed cmake packages
|
@jenisys you should enable the GitHub Actions under Settings! |
ClausKlein
commented
Feb 28, 2021
| @@ -30,7 +30,7 @@ endif() | |||
| # SANE DEFAULTS: If ".cmake_project.cxx_standard" is missing | |||
| # --------------------------------------------------------------------------- | |||
| if(NOT DEFINED CMAKE_CXX_STANDARD) | |||
| set(CMAKE_CXX_STANDARD 17) # Enable C++17 standard | |||
| set(CMAKE_CXX_STANDARD 20) # Enable C++20 standard | |||
There was a problem hiding this comment.
maybe we should not change this?
|
@jenisys there is still an open problem: the findsyslog.cmake module is not installed! So downstream can't use it. see https://pabloariasal.github.io/2018/02/19/its-time-to-do-cmake-right/ |
now it can be used:
find_package(simplelog COMPONENTS simplelog null spdlog syslog)
ClausKlein
commented
Mar 1, 2021
| include(ccache) | ||
| include(cxx.setup_project) | ||
|
|
||
| find_package(simplelog COMPONENTS null spdlog syslog) |
There was a problem hiding this comment.
@jenisys Note: this works now!
| ) | ||
| endif() | ||
|
|
||
| if(SIMPLELOG_USE_BACKEND_SYSTEMD) |
There was a problem hiding this comment.
without this the install cmake config set was not useable!
check cppcoreguidlines too
cleanup GNUmakefile to run with clang-tidy needed patch witch perlscript used
this break MSVC build on windows
this breaks windows build too
Note: WarningsAsErrors will still break the build!
Repository owner
deleted a comment from
ClausKlein
Mar 6, 2021
|
While this PR may contains some improvements and fixes it violates the best practices for an PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use CMP.cmake
cleanup cmake files
prevent warnings, but not all
setup GitHub Actions for CI see https://github.com/ClausKlein/cxx.simplelog/runs/1998057440?check_suite_focus=true
this fix
#2
#3
#4
and some of (#6)