Skip to content

Commit

Permalink
Azure File Share Principal geoip on publick8s expires on `2024-12…
Browse files Browse the repository at this point in the history
…-23T00:00:00Z` (#916)

This PR updates the end date of geoip File Share service principal
writer used in publick8s for geoip.

The current end date is set to `2024-12-23T00:00:00Z`.

> [!IMPORTANT]
>
> ⚠️ Merging this PR will prevent the "geoip kubernetes cronjob" to
succeed and update the mirrorbits geoip databases.
> You'll have to update the sops secrets
`./secrets/config/geoipdata/secrets.yaml`
>
> This credential value can be retrieved in the Terraform state from
`module.cronjob_geoip_data_fileshare_serviceprincipal_writer.azuread_application.fileshare_serviceprincipal_writer_application_client_password`.


---



<Actions>
<action
id="db89237fe6ac1ab94bffe93d33dd77280725d9cb1b09f28d57784a903330297f">
<h3>Generate new end date for geoip File Share service principal writer
on publick8s</h3>
<details
id="4191ba5f46dbb754c1e7d30549ffcee986a6a05817c850ea79cf471743ba992d">
<summary>New end date for `geoip` File Share service principal writer on
`publick8s` (current: 2024-12-23T00:00:00Z)</summary>
<p>changes detected:&#xA;&#x9;path
&#34;module.cronjob_geoip_data_fileshare_serviceprincipal_writer.service_principal_end_date&#34;
updated from &#34;2024-12-23T00:00:00Z&#34; to
&#34;2025-04-08T00:00:00Z&#34; in file &#34;publick8s.tf&#34;</p>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/633/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
  • Loading branch information
1 parent 9295718 commit cd32116
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion publick8s.tf
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ module "cronjob_geoip_data_fileshare_serviceprincipal_writer" {
service_fqdn = "${azurerm_resource_group.publick8s.name}-fileshare_serviceprincipal_writer-redirects"
active_directory_owners = [data.azuread_service_principal.terraform_production.object_id]
active_directory_url = "https://github.com/jenkins-infra/azure"
service_principal_end_date = "2024-12-23T00:00:00Z"
service_principal_end_date = "2025-04-08T00:00:00Z"
file_share_resource_manager_id = azurerm_storage_share.geoip_data.resource_manager_id
storage_account_id = azurerm_storage_account.publick8s.id
default_tags = local.default_tags
Expand Down

0 comments on commit cd32116

Please sign in to comment.