Support clean release version without changelist #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusbunsi
added a commit
to justusbunsi/gitea-plugin
that referenced
this pull request
Nov 21, 2021
justusbunsi
changed the title
lafriks
pushed a commit
to jenkinsci/gitea-plugin
that referenced
this pull request
Nov 21, 2021
* Add alt-texts to badges This is a commit for letting the status checks fail. * Lower the release version * Re-Add changelist to version * Opt-out incremental suffix during release See: jenkins-infra/jenkins-maven-cd-action#13 * Auto-incrementalify after release
viceice
added a commit
to visualon/jenkins-gitea-plugin
that referenced
this pull request
Nov 24, 2021
* Enable cd workflow (#35) * Enable cd workflow Signed-off-by: Steven Kriegler <[email protected]> * Add missing GitHub workflow Signed-off-by: Steven Kriegler <[email protected]> * Update .github/workflows/cd.yaml Co-authored-by: Lauris BH <[email protected]> * Switch back to classic version syntax Co-authored-by: Lauris BH <[email protected]> * Bump version to 1.5.0 (jenkinsci#42) Additionally: Fix tag/release template to match previous releases * Fix release versioning + incremental builds (jenkinsci#43) * Add alt-texts to badges This is a commit for letting the status checks fail. * Lower the release version * Re-Add changelist to version * Opt-out incremental suffix during release See: jenkins-infra/jenkins-maven-cd-action#13 * Auto-incrementalify after release * Fix JENKINS-67068 (jenkinsci#44) As a result of PR #29 it happens that some users cannot fetch branches with slashes in their names anymore. Regression from: JENKINS-65796 Co-authored-by: Steven <[email protected]> Co-authored-by: Lauris BH <[email protected]>
|
I hope to support plugins still using MRP, but not this way. |
|
Anything I could change so that it would fit better? Or do you not want to support such clean versions in general? |
|
See #14, to be used for components which cannot use full JEP-229. Not recommended in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many plugins have a clean version for a stable release, such as Blue Ocean or similar. It seems that they don't use this workflow action as it currently creates releases such as for the Gitea plugin.
This PR adds the possibility to opt-out incremental/snapshot/rc suffixes during plugin release/deploy and for creating the actual GitHub release from a previously created draft. By default the suffix will be used.
Additionally resolves: #6