fix: fix failing lighthouse builds

[ankitm123]

Signed-off-by: ankitm123 [email protected]

[ankitm123]

Lighthouse builds are failing atm with the error:

# github.com/jenkins-x/lighthouse/pkg/webhook
--
  |   |   |   | pkg/webhook/events.go:69:16: cannot use ic.Issue.PullRequest (variable of type scm.PullRequest) as type bool in struct literal
  |   |   |   | pkg/webhook/events.go:82:5: non-boolean condition in if statement
  |   |   |   | make: *** [Makefile:76: build-webhooks-linux] Error 2

Passing a pointer to a struct, will help in checking if it's nil and determine if it's a PR or not.

[ankitm123]

@garethjevans probably worth running integration tests to be sure this works?

[ankitm123]

Breaks here: https://github.com/jenkins-x/lighthouse/blob/03e54f647abcd82dc3dd662206e28fb13a1d13df/pkg/webhook/events.go#L69 and https://github.com/jenkins-x/lighthouse/blob/03e54f647abcd82dc3dd662206e28fb13a1d13df/pkg/webhook/events.go#L82 as it was relying on boolean return.

[garethjevans]

@ankitm123 thanks for the heads up, i'll get the tests run today

[garethjevans]

/lgtm

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [garethjevans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment