Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery from 1.x to 3.x #69

Merged
merged 2 commits into from
May 9, 2023
Merged

Upgrade jQuery from 1.x to 3.x #69

merged 2 commits into from
May 9, 2023

Conversation

basil
Copy link
Member

@basil basil commented May 4, 2023

Upgrades jQuery from 1.x to 3.x by depending on the jquery3-api plugin. This is the last plugin that depends on stapler-adjunct-jquery 1.x, which we would like to deprecate.

I have not tested this change, and I do not use this plugin (nor could I figure out how to use it in five minutes), so please test this change interactively in the GUI before merging and releasing it.

@kinow
Copy link
Member

kinow commented May 4, 2023

Thank you @basil !!!

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passing, and also spent some time to sync, build, and test the new code. Found no issues with a basic example project 👍 Thank you @basil !

image

@kinow kinow merged commit 58d20b2 into jenkinsci:master May 9, 2023
@basil basil deleted the jquery3 branch May 9, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants