Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Eclipse Temurin, not AdoptOpenJDK in action #46

Closed
wants to merge 2 commits into from

Conversation

MarkEWaite
Copy link

@MarkEWaite MarkEWaite commented Mar 27, 2022

The 'adopt' distribution has moved to Eclipse Temurin and won't be updated at the AdoptOpenJDK location.

See jenkinsci/jenkins#6406

https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#adopt

https://github.com/actions/setup-java#usage

Supersedes #48

@MarkEWaite MarkEWaite requested a review from a team as a code owner March 27, 2022 13:06
Copy link
Contributor

@ahmed-musallam ahmed-musallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/cd.yaml Outdated Show resolved Hide resolved
Declare only the major version of setup-java
because we have no facility to evaluate new 
versions in a CI job.
@MarkEWaite
Copy link
Author

Closing in favor of #56

@MarkEWaite MarkEWaite closed this Jul 23, 2022
@MarkEWaite MarkEWaite deleted the use-temurin-for-cd branch July 23, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants