-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-61855] Add Support for Doxygen Warnings. #1149
Conversation
Hello @uhafner can you please review this? |
Hello @uhafner even though there is no check style warnings now why the tests are failing? Isn't 13.1.0 is the latest? I've also pulled everything before pushing |
RevApi is complaining that you changed the base class of an API class. Normally, this is a breaking change. However, all parsers are not part of the API now. I fixed the RevApi configuration in b18d9c4 Can you please rebase and retry? |
Got it! I will retry again after rebasing. |
Hello @uhafner I've rebased to the latest main and the errors are gone. |
a75530a
to
b893501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good. I think reusing the other method is fine...
} | ||
|
||
@SuppressWarnings("PMD.AvoidLiteralsInIfCondition") | ||
private boolean isMessageContinuation(final LookaheadStream lookahead) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you make the method package private and static in GccParser? Then we can reuse it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. You're right! Good suggestion
I've made the requested changes. |
Thanks! |
Testing done
FIXES - JENKINS-61855
Added Support for Doxygen Warnings having format -
file_path(line):col: Warning/Error: message
along with the existing format -file_path:line:col: Warning/Error: message
Submitter checklist