Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-61855] Add Support for Doxygen Warnings. #1149

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

code-arnab
Copy link
Contributor

Testing done

FIXES - JENKINS-61855

Added Support for Doxygen Warnings having format -
file_path(line):col: Warning/Error: message along with the existing format -
file_path:line:col: Warning/Error: message

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@code-arnab
Copy link
Contributor Author

Hello @uhafner can you please review this?

@uhafner uhafner added the bug Bugs or performance problems label Feb 24, 2025
@code-arnab
Copy link
Contributor Author

code-arnab commented Feb 24, 2025

Hello @uhafner even though there is no check style warnings now why the tests are failing?
Also the Jenkins build is showing this before error, is this relevant -
Comparing [edu.hm.hafner:analysis-model:jar:13.1.0] against [edu.hm.hafner:analysis-model:jar:13.2.0-rc6073.5950e5eb_6fa_b_] (including their transitive dependencies).

Isn't 13.1.0 is the latest? I've also pulled everything before pushing

@uhafner
Copy link
Member

uhafner commented Feb 24, 2025

RevApi is complaining that you changed the base class of an API class. Normally, this is a breaking change.

However, all parsers are not part of the API now. I fixed the RevApi configuration in b18d9c4

Can you please rebase and retry?

@code-arnab
Copy link
Contributor Author

code-arnab commented Feb 25, 2025

RevApi is complaining that you changed the base class of an API class. Normally, this is a breaking change.

However, all parsers are not part of the API now. I fixed the RevApi configuration in b18d9c4

Can you please rebase and retry?

Got it! I will retry again after rebasing.

@code-arnab
Copy link
Contributor Author

code-arnab commented Feb 25, 2025

Hello @uhafner I've rebased to the latest main and the errors are gone.
I have a question - Do you think there is any need of having the isMessageContinuation method, that I have borrowed from GCC4 Parser?

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good. I think reusing the other method is fine...

}

@SuppressWarnings("PMD.AvoidLiteralsInIfCondition")
private boolean isMessageContinuation(final LookaheadStream lookahead) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you make the method package private and static in GccParser? Then we can reuse it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. You're right! Good suggestion

@code-arnab
Copy link
Contributor Author

I've made the requested changes.

@uhafner
Copy link
Member

uhafner commented Feb 25, 2025

Thanks!

@uhafner uhafner merged commit 276cb43 into jenkinsci:main Feb 25, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants