Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting in HelloWorldBuilderTest #630

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 2, 2023

Spotless reformatting (#619) defeated the purpose of the original manual formatting, which was to show the indentation of the Groovy script embedded in Java sources. This just seems to be impossible in Spotless, at least until we are on a new enough version of Java that we can use multiline string literals. (Some projects also use external src/test/resources/**/*.groovy, which has its own advantages of course, but forces readers and editors to flip back and forth between files for a single test case.)

@jglick jglick merged commit 2f1093e into jenkinsci:master Jun 2, 2023
@jglick jglick deleted the HelloWorldBuilderTest-formatting branch June 2, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants