Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60040] Update to jclouds 2.2.0 #102

Merged
merged 3 commits into from
Dec 4, 2019
Merged

[JENKINS-60040] Update to jclouds 2.2.0 #102

merged 3 commits into from
Dec 4, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 3, 2019 •
edited
Loading

Mainly to pick up JCLOUDS-1447 jclouds/jclouds#1238, fixing various problems with special characters such as JENKINS-60040, but see full release notes.

Supersedes #99.

@jglick jglick requested a review from davidcurrie December 3, 2019 18:15
jglick
jglick commented Dec 3, 2019
View reviewed changes
src/test/java/io/jenkins/plugins/artifact_manager_jclouds/MockApiMetadata.java
@@ -193,12 +190,13 @@ public boolean blobExists(String container, String key) {
}

@Override
public Iterable<String> getBlobKeysInsideContainer(String container) throws IOException {
public Iterable<String> getBlobKeysInsideContainer(String container, String prefix) throws IOException {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapts to apache/jclouds@29eec44

@jglick
Copy link
Member Author

jglick commented Dec 3, 2019

Got

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertFalse(Assert.java:64)
	at org.junit.Assert.assertFalse(Assert.java:74)
	at org.jenkinsci.plugins.workflow.ArtifactManagerTest.lambda$artifactArchiveAndDelete$1(ArtifactManagerTest.java:159)
	at org.jenkinsci.plugins.workflow.ArtifactManagerTest.wrapInContainer(ArtifactManagerTest.java:125)
	at org.jenkinsci.plugins.workflow.ArtifactManagerTest.artifactArchiveAndDelete(ArtifactManagerTest.java:154)
	at io.jenkins.plugins.artifact_manager_jclouds.s3.JCloudsArtifactManagerTest.artifactArchiveAndDelete(JCloudsArtifactManagerTest.java:187)

but it seems to have been a flake, as the test class passed when rerun.

@jglick jglick marked this pull request as ready for review December 3, 2019 18:47
@jglick jglick changed the title Update to jclouds 2.2.0 [JENKINS-60040] Update to jclouds 2.2.0 Dec 3, 2019
@jglick jglick added the bug Something isn't working label Dec 3, 2019
@jglick jglick requested a review from carlossg December 3, 2019 22:53
@jglick jglick merged commit 4053ee9 into jenkinsci:master Dec 4, 2019
@jglick jglick deleted the jclouds-update branch December 4, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richbg richbg richbg approved these changes

@davidcurrie davidcurrie Awaiting requested review from davidcurrie

@carlossg carlossg Awaiting requested review from carlossg

Assignees
No one assigned
Labels
bug Something isn't working dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @richbg