Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-50597] Introduce mocking framework and start to resolve network reliability issues #33

Merged
merged 15 commits into from
May 24, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented May 24, 2018

Refiled from #28. Used as a basis for testing network issues (JENKINS-50597).

@jglick jglick requested review from carlossg and kuisathaverat May 24, 2018 14:29
pom.xml Outdated
<!-- to make it work in eclipse during development -->
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides functional tests covered by CI, I checked that this still works in hpi:run and also java -jar jenkins.war.

Copy link
Contributor

@carlossg carlossg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing some docs on implementation election and classes

@jglick jglick requested a review from carlossg May 24, 2018 16:00
@jglick jglick merged commit cb85963 into master May 24, 2018
@jglick jglick deleted the jclouds-mock branch May 24, 2018 17:48
@jglick jglick mentioned this pull request Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants