-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing Spotbugs level and fixing Spotbugs issues #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneveux
commented
Nov 24, 2022
src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Dec 5, 2022
src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfigTest.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Jan 5, 2023
src/test/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfigTest.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Jan 5, 2023
src/main/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/io/jenkins/plugins/artifact_manager_jclouds/s3/S3BlobStoreConfigTest.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
import io.jenkins.plugins.artifact_manager_jclouds.BlobStoreProvider; | ||
import io.jenkins.plugins.artifact_manager_jclouds.JCloudsArtifactManagerFactory; | ||
|
||
import hudson.model.Failure; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunate. Guess I need to set up Spotless to enforce simple lexicographical import
sorting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks 👋
I'm currently following the Improve a Plugin documentation for
Jenkins plugins modernization, and noticed we could add more Spotbugs checks in this plugin.
So here's a PR following the documentation recommendation by increasing the Spotbugs checks, as well as fixing the
reported issues.
Let me know if that sounds interesting to you or if any other modifications are needed.
Thanks a lot!