Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing Spotbugs level and fixing Spotbugs issues #339

Merged
merged 6 commits into from
Jan 5, 2023

Conversation

aneveux
Copy link
Member

@aneveux aneveux commented Nov 24, 2022

Hello folks 👋

I'm currently following the Improve a Plugin documentation for
Jenkins plugins modernization, and noticed we could add more Spotbugs checks in this plugin.

So here's a PR following the documentation recommendation by increasing the Spotbugs checks, as well as fixing the
reported issues.

Let me know if that sounds interesting to you or if any other modifications are needed.

Thanks a lot!

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira // I do not have a Jira issue for that. Should I create one?
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@aneveux aneveux requested a review from jglick January 5, 2023 14:57
@jglick jglick added the chore label Jan 5, 2023
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

import io.jenkins.plugins.artifact_manager_jclouds.BlobStoreProvider;
import io.jenkins.plugins.artifact_manager_jclouds.JCloudsArtifactManagerFactory;

import hudson.model.Failure;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate. Guess I need to set up Spotless to enforce simple lexicographical import sorting.

@jglick jglick merged commit f16d037 into jenkinsci:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants