-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Jenkins core 2.401 and refresh dependencies #449
Bump to Jenkins core 2.401 and refresh dependencies #449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this fails tests
java.lang.NoClassDefFoundError: org/joda/time/ReadableInstant
at com.amazonaws.services.s3.internal.ServiceUtils.<clinit>(ServiceUtils.java:74)
at com.amazonaws.services.s3.AmazonS3Client.setEndpoint(AmazonS3Client.java:756)
at com.amazonaws.services.s3.AmazonS3Client.init(AmazonS3Client.java:740)
at com.amazonaws.services.s3.AmazonS3Client.<init>(AmazonS3Client.java:730)
at com.amazonaws.services.s3.AmazonS3Builder$1.apply(AmazonS3Builder.java:35)
at com.amazonaws.services.s3.AmazonS3Builder$1.apply(AmazonS3Builder.java:32)
at com.amazonaws.services.s3.AmazonS3ClientBuilder.build(AmazonS3ClientBuilder.java:64)
at com.amazonaws.services.s3.AmazonS3ClientBuilder.build(AmazonS3ClientBuilder.java:28)
at com.amazonaws.client.builder.AwsSyncClientBuilder.build(AwsSyncClientBuilder.java:46)
at io.jenkins.plugins.artifact_manager_jclouds.s3.S3AbstractTest.live(S3AbstractTest.java:75)
but that was not caught by the minority of tests which are able to run on ci.jenkins.io: jenkinsci/bom#1338 (comment)
@@ -74,12 +77,18 @@ | |||
<dependency> | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>aws-credentials</artifactId> | |||
<version>191.vcb_f183ce58b_9</version> | |||
<exclusions> | |||
<!-- TODO JCLOUDS-1620 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://issues.apache.org/jira/browse/JCLOUDS-1620 FTR. Serious problems would I hope get caught by
Line 73 in 87eb541
public RealJenkinsRule rr = new RealJenkinsRule().javaOptions("-Xmx150m"); |
artifact-manager-s3-plugin/pom.xml
Lines 66 to 68 in 29d44d4
<groupId>org.apache.jclouds.provider</groupId> | |
<artifactId>aws-s3</artifactId> | |
<version>2.5.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this relate to #447?
And use bom version when possible
#446
#445
#444
#436
#435
#428
#420
#418
#403
Testing done
Automated tests
Submitter checklist