Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Jenkins core 2.401 and refresh dependencies #449

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jonesbusy
Copy link
Contributor

And use bom version when possible

#446
#445
#444
#436
#435
#428
#420
#418
#403

Testing done

Automated tests

Submitter checklist

Preview Give feedback

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this fails tests

java.lang.NoClassDefFoundError: org/joda/time/ReadableInstant
	at com.amazonaws.services.s3.internal.ServiceUtils.<clinit>(ServiceUtils.java:74)
	at com.amazonaws.services.s3.AmazonS3Client.setEndpoint(AmazonS3Client.java:756)
	at com.amazonaws.services.s3.AmazonS3Client.init(AmazonS3Client.java:740)
	at com.amazonaws.services.s3.AmazonS3Client.<init>(AmazonS3Client.java:730)
	at com.amazonaws.services.s3.AmazonS3Builder$1.apply(AmazonS3Builder.java:35)
	at com.amazonaws.services.s3.AmazonS3Builder$1.apply(AmazonS3Builder.java:32)
	at com.amazonaws.services.s3.AmazonS3ClientBuilder.build(AmazonS3ClientBuilder.java:64)
	at com.amazonaws.services.s3.AmazonS3ClientBuilder.build(AmazonS3ClientBuilder.java:28)
	at com.amazonaws.client.builder.AwsSyncClientBuilder.build(AwsSyncClientBuilder.java:46)
	at io.jenkins.plugins.artifact_manager_jclouds.s3.S3AbstractTest.live(S3AbstractTest.java:75)

but that was not caught by the minority of tests which are able to run on ci.jenkins.io: jenkinsci/bom#1338 (comment)

@@ -74,12 +77,18 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>aws-credentials</artifactId>
<version>191.vcb_f183ce58b_9</version>
<exclusions>
<!-- TODO JCLOUDS-1620 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/JCLOUDS-1620 FTR. Serious problems would I hope get caught by

public RealJenkinsRule rr = new RealJenkinsRule().javaOptions("-Xmx150m");
Supposedly fixed in 2.6.0
<groupId>org.apache.jclouds.provider</groupId>
<artifactId>aws-s3</artifactId>
<version>2.5.0</version>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this relate to #447?

@jglick
Copy link
Member

jglick commented Jan 17, 2024

@jglick jglick merged commit 29d44d4 into jenkinsci:master Jan 30, 2024
14 checks passed
@jonesbusy jonesbusy deleted the feature/refresh-dependencies branch January 30, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants