Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-50591][JCLOUDS-1401] Add test that shows jclouds issue #9

Merged
merged 3 commits into from
Apr 6, 2018
Merged

[JENKINS-50591][JCLOUDS-1401] Add test that shows jclouds issue #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eac0c92
[JENKINS-50591][JCLOUDS-1401] Add test that shows jclouds issue
carlossg Apr 5, 2018
dd963e3
[JENKINS-50591] Use @Ignore
carlossg Apr 5, 2018
4392c8c
Merge branch 'master' into JENKINS-50591
carlossg Apr 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/test/java/io/jenkins/plugins/artifact_manager_s3/JCloudsBlobStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,35 @@
package io.jenkins.plugins.artifact_manager_s3;

import static org.hamcrest.Matchers.*;
import static org.jclouds.blobstore.options.ListContainerOptions.Builder.*;
import static org.junit.Assert.*;

import java.io.File;
import java.io.FileNotFoundException;
import java.io.InputStream;
import java.net.URI;
import java.util.Arrays;
import java.util.List;
import java.util.logging.Level;

import org.apache.commons.io.FileUtils;
import org.apache.commons.io.IOUtils;
import org.jclouds.blobstore.domain.Blob;
import org.jclouds.blobstore.domain.PageSet;
import org.jclouds.blobstore.domain.StorageMetadata;
import org.jclouds.rest.internal.InvokeHttpMethod;
import org.junit.After;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.jvnet.hudson.test.Issue;
import org.jvnet.hudson.test.LoggerRule;

import com.amazonaws.services.s3.AmazonS3;
import com.amazonaws.services.s3.AmazonS3ClientBuilder;
import com.amazonaws.services.s3.model.ListObjectsV2Result;
import com.amazonaws.services.s3.model.S3ObjectSummary;

import jenkins.util.VirtualFile;
import shaded.com.google.common.collect.ImmutableSet;

Expand Down Expand Up @@ -232,4 +243,27 @@ public void toURI() throws Exception {
newJCloudsBlobStore("xxx#?:$&'\"<>čॐ").toURI());
}

@Ignore("blocked by jClouds issue")
@Test
@Issue({ "JENKINS-50591", "JCLOUDS-1401" })
public void testAmpersand() throws Exception {
String key = getPrefix() + "xxx#?:&$'\"<>čॐ";

try {
blobStore.putBlob(getContainer(), blobStore.blobBuilder(key).payload("test").build());

final AmazonS3 s3 = AmazonS3ClientBuilder.defaultClient();
ListObjectsV2Result result = s3.listObjectsV2(getContainer(), key);
List<S3ObjectSummary> objects = result.getObjectSummaries();
assertThat(objects, not(empty()));

// fails with
// org.jclouds.rest.AuthorizationException: The request signature we calculated does not match the signature
// you provided. Check your key and signing method.
PageSet<? extends StorageMetadata> list = blobStore.list(getContainer(), prefix(key));
assertThat(list, not(empty()));
} finally {
blobStore.removeBlob(getContainer(), key);
}
}
}