Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #92

Merged
merged 4 commits into from
Apr 11, 2019
Merged

Updates #92

merged 4 commits into from
Apr 11, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 10, 2019

Subsumes #91. @richbg

@jglick jglick requested review from carlossg and batmat April 10, 2019 15:11
@jglick jglick marked this pull request as ready for review April 10, 2019 16:33
batmat
batmat approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool findings.
Some unrelated WS changes afaict, but that's fine.

@jglick
Copy link
Member Author

jglick commented Apr 10, 2019

Some unrelated WS changes afaict

Where? I had to fix an import after a package rename of a dep.

@batmat
Copy link
Member

batmat commented Apr 11, 2019

Cannot see anything anymore about WS changes at the bottom. Given there's nothing anymore, I'm going to assume either I was drunk, or GitHub UI was getting crazy, or both.
Anyway, bottom line is that we're fine and even more good to go \o/.

Thanks

@batmat
Copy link
Member

batmat commented Apr 11, 2019

@jenkinsci/java11-support FYI

@jglick jglick merged commit 965915b into jenkinsci:master Apr 11, 2019
@jglick jglick deleted the updates branch April 11, 2019 19:31
@jglick jglick mentioned this pull request Apr 11, 2019
Merged
@oleg-nenashev
Copy link
Member

Cutting a release right now. Will be in 1.5

@oleg-nenashev
Copy link
Member

@jglick 9da9495 is not clear to me. Is it a separate bugfix? Does it need a changelog?

@jglick
Copy link
Member Author

jglick commented May 6, 2019

It is the fix for the minor regression that PCT uncovered.

This was referenced May 23, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batmat batmat batmat approved these changes

@carlossg carlossg Awaiting requested review from carlossg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @batmat @oleg-nenashev