Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-69229] Revert trilead-api update #1379

Merged
merged 2 commits into from
Aug 6, 2022
Merged

[JENKINS-69229] Revert trilead-api update #1379

merged 2 commits into from
Aug 6, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 4, 2022

Reverting #1374. #1378 (comment)

@jglick jglick added the dependencies Pull requests that update a dependency file label Aug 4, 2022
@jglick
Copy link
Member Author

jglick commented Aug 4, 2022

OK let us go with this one for now.

@jglick jglick enabled auto-merge (squash) August 4, 2022 14:58
@jglick jglick mentioned this pull request Aug 4, 2022
Closed
@jglick
Copy link
Member Author

jglick commented Aug 5, 2022

https://github.com/jenkinsci/bom/pull/1379/checks?check_run_id=7686535482 (second flake in this PR)

WARNING	o.j.p.w.cps.CpsFlowExecution#cleanUpHeap: failed to clean up memory from Owner[demo/1:demo #1]
java.lang.ClassCastException: class java.io.ObjectStreamClass$Caches$1 cannot be cast to class java.util.concurrent.ConcurrentMap (java.io.ObjectStreamClass$Caches$1 and java.util.concurrent.ConcurrentMap are in module java.base of loader 'bootstrap')
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.cleanUpObjectStreamClassCaches(CpsFlowExecution.java:1426)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.cleanUpLoader(CpsFlowExecution.java:1321)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.cleanUpLoader(CpsFlowExecution.java:1300)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.cleanUpLoader(CpsFlowExecution.java:1310)
	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.cleanUpHeap(CpsFlowExecution.java:1287)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:447)
	at …

@jglick jglick mentioned this pull request Aug 5, 2022
Merged
@basil basil disabled auto-merge August 5, 2022 23:07
@basil basil enabled auto-merge (squash) August 5, 2022 23:08
@basil basil merged commit 2d71dba into jenkinsci:master Aug 6, 2022
jglick
jglick commented Aug 6, 2022
View reviewed changes
.github/dependabot.yml
@@ -16,6 +16,11 @@ updates:
- "jglick"
schedule:
interval: "daily"
ignore:
# TODO https://github.com/jenkinsci/bom/pull/1374#issuecomment-1205302760 pending new version
- dependency-name: trilead-api
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1382 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a86fa42

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jenkinsci/trilead-api-plugin/releases/tag/2.72.v2a_3236754f73 includes jenkinsci/trilead-api-plugin#55 which I guess is now safe for newer lines @kuisathaverat?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is safe for 2.261+

@jglick jglick deleted the trilead-api-JENKINS-69229-II branch August 7, 2022 20:37
@jglick jglick mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@basil basil basil approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@jtnord jtnord jtnord approved these changes

@jetersen jetersen jetersen approved these changes

@timja timja timja approved these changes

@daniel-beck daniel-beck Awaiting requested review from daniel-beck

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jglick @basil @MarkEWaite @jtnord @jetersen @kuisathaverat @timja