Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with the Metrics plugin #141

Merged

Conversation

jamesrobson-secondmind
Copy link
Contributor

@jamesrobson-secondmind jamesrobson-secondmind commented Jun 4, 2021

This adds integration with the Metrics plugin to replace the graphs that were removed by version 2, this will allow users to integrate with there own metrics systems (e.g. Prometheus or Data Dog).
This uses a counter from the Metrics library which will reset when jenkins is restarted which was done for implementation simplicity.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jamesrobson-secondmind jamesrobson-secondmind force-pushed the metrics-plugin-integration branch from 8a6197b to b0f993b Compare June 7, 2021 13:51
@jamesrobson-secondmind jamesrobson-secondmind marked this pull request as ready for review June 21, 2021 16:14
@jamesrobson-secondmind jamesrobson-secondmind force-pushed the metrics-plugin-integration branch 2 times, most recently from 028aaa9 to cd838d6 Compare September 15, 2021 15:48
@malashi
Copy link

malashi commented Sep 18, 2021

can this be merged now?

@jamesrobson-secondmind
Copy link
Contributor Author

Yes, this is ready to merge now.

@rsandell rsandell merged commit 88a513f into jenkinsci:master Sep 24, 2021
@rsandell rsandell mentioned this pull request Sep 24, 2021
@PayBas
Copy link

PayBas commented Oct 1, 2021

I feel that there is a big omission here: the "Fallback categories"
image

@jamesrobson-secondmind
Copy link
Contributor Author

Yes, that's a missing feature which I'll look at adding.

@jamesrobson-secondmind jamesrobson-secondmind deleted the metrics-plugin-integration branch October 8, 2021 15:24
@jamesrobson-secondmind
Copy link
Contributor Author

#148 fixes the fallback categories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants