Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default settings to Build Monitor Views #425

Closed
wants to merge 5 commits into from
Closed

Add default settings to Build Monitor Views #425

wants to merge 5 commits into from

Conversation

timbrown5
Copy link

  • Added settings items to config so default settings can be tracked
    in the plugin, not just the cookie.
  • Updated configure-entries.jelly to allow setting of the settings.
  • Updated main.settings.jelly to pass default settings from plugin to
    settings.js. Also added a new button to reset settings in cookie to
    default.
  • Updated settings.js to use the default settings provided by
    main.settings.jelly. Also added a function to reset settings cookie
    to the default value.

I opened a new pull request as #419 was closed when I deleted the remote branch.

@timbrown5
Add default settings to Build Monitor Views
94995a3 
- Added settings items to config so default settings can be tracked
  in the plugin, not just the cookie.
- Updated configure-entries.jelly to allow setting of the settings.
- Updated main.settings.jelly to pass default settings from plugin to
  settings.js. Also added a new button to reset settings in cookie to
  default.
- Updated settings.js to use the default settings provided by
  main.settings.jelly. Also added a function to reset settings cookie
  to the default value.
@timja
Copy link
Member

timja commented Oct 23, 2019

Tests are failing, possibly legitimate failures?

@timbrown5
Copy link
Author

timbrown5 commented Oct 23, 2019 •
edited
Loading

Tests are failing, possibly legitimate failures?

Yes, looks like when a new Build Monitor is created the default settings used are not the ones defined in Config.java.
The number of columns is defaulting to 0, which hides all the builds from the dashboard. I think allowing users to set 0 columns is also a bug, as the dashboard becomes useless.

@timbrown5
Copy link
Author

Looks like the job passed but 4 tests failed to find objects using xpath.

@timbrown5
Copy link
Author

timbrown5 commented Oct 23, 2019 •
edited
Loading

Looks like the job passed but 4 tests failed to find objects using xpath.

Looks like there are similar failures in master builds.
https://travis-ci.org/jan-molak/jenkins-build-monitor-plugin/jobs/596586973
https://travis-ci.org/jan-molak/jenkins-build-monitor-plugin/jobs/596538393

Is it that there are some flakey tests which get rerun?

@timbrown5
Copy link
Author

@timja Thanks for the help.
Unless I hear otherwise I will assume this just needs merging.

@MarkTickner
Copy link

Is there any progress with this? This is a feature I'm looking forward to

@timja
Copy link
Member

timja commented Oct 31, 2019

@jan-molak

@timbrown5
Copy link
Author

Any update on when this might be merged?

@timbrown5
Copy link
Author

@jan-molak Do you know when this might get merged?

@timbrown5
Copy link
Author

Any update of when this will get merged?

@dcendents dcendents mentioned this pull request Feb 14, 2022
Merged
@basil basil closed this in #573 Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timbrown5 @timja @MarkTickner