Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ability to hide header and footer #57

Closed
wants to merge 2 commits into from
Closed

Feature: Ability to hide header and footer #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a904659
Feature: Ability to hide header and footer #38
Mar 17, 2014
2fa4033
Hiding the footer does not stop the broken-connection notifier displa…
Nov 23, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...in/resources/com/smartcodeltd/jenkinsci/plugins/buildmonitor/BuildMonitorView/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
<div class="build-monitor dashboard industrial"
data-ng-app="buildMonitor"
data-ng-controller="JobViews">
<header>
<header ng-show="settings.showHeader">
<a class="home-link" href="${rootURL}/" title="Jenkins">Jenkins</a>
<h1><a href="configure" title="Configure the '${it.title}' view">${it.title}</a></h1>
</header>
Expand All @@ -99,7 +99,7 @@

<footer>
<notifier />
<span class="plugin-author">
<span class="plugin-author" ng-show="settings.showHeader">
<a href="https://github.com/jan-molak/jenkins-build-monitor-plugin" title="Learn more about the Build Monitor project" rel="external">Build Monitor</a>
version <a href="https://github.com/jan-molak/jenkins-build-monitor-plugin/releases" title="Is your Build Monitor up to date?" rel="external">${it.installation.buildMonitorVersion()}</a>
brought to you by <a href="http://smartcodeltd.co.uk" rel="external">Jan Molak</a>
Expand Down Expand Up @@ -171,4 +171,4 @@
</script>
</body>
</html>
</j:jelly>
</j:jelly>
7 changes: 7 additions & 0 deletions ...rces/com/smartcodeltd/jenkinsci/plugins/buildmonitor/BuildMonitorView/main-settings.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
<span class="slider-label">Columns</span>
<slider floor="1" ceiling="8" step="1" precision="0" data-ng-model="settings.numberOfColumns"></slider>
</li>
<li>
<input data-ng-model="settings.showHeader"
data-ng-false-value="0"
data-ng-true-value="1"
id="settings-show-header" type="checkbox" />
<label for="settings-show-header" title="Show page header and footer">Show Header and Footer?</label>
</li>
<li>
<input data-ng-model="settings.colourBlind"
data-ng-false-value="0"
Expand Down
1 change: 1 addition & 0 deletions src/main/webapp/scripts/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ angular.
$scope.settings.fontSize = cookieJar.get('fontSize', 1);
$scope.settings.numberOfColumns = cookieJar.get('numberOfColumns', 2);
$scope.settings.colourBlind = cookieJar.get('colourBlind', 0);
$scope.settings.showHeader = cookieJar.get('showHeader', 1);

angular.forEach($scope.settings, function(value, name) {
$scope.$watch('settings.' + name, function(currentValue) {
Expand Down
5 changes: 1 addition & 4 deletions src/main/webapp/themes/industrial.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ h2 {
}

.build-monitor footer span {
height:24px;
line-height: 150%;
}

Expand Down Expand Up @@ -297,10 +298,6 @@ h2 {
padding:5em 0 0 0;
}

.build-monitor footer {
height:24px;
}

.build-monitor ul#job-views {
list-style-type: none;
margin: 4px;
Expand Down