Migrate from EE 8 to EE 9 #444
Conversation
basil
force-pushed
the
jakarta
branch
2 times, most recently
from
ee250fa to
50cbd7f
Compare
| @@ -1092,13 +1159,39 @@ public void renameTo(String newName) throws IOException { | |||
| * {@inheritDoc} | |||
| */ | |||
| @Override | |||
| public synchronized void doSubmitDescription(StaplerRequest req, StaplerResponse rsp) throws IOException, ServletException { | |||
| public synchronized void doSubmitDescription(StaplerRequest2 req, StaplerResponse2 rsp) throws IOException, ServletException { | |||
| if (Util.isOverridden(AbstractFolder.class, getClass(), "doSubmitDescription", StaplerRequest.class, StaplerResponse.class)) { | |||
There was a problem hiding this comment.
Most if not all of these web methods could probably be simplified considerably by just deleting the deprecated overload, which I doubt is either called programmatically or overridden by any known subclass. Pending that, it would make sense to mark the new overloads final and/or @Restricted(NoExternalUse.class) unless and until some legitimate use case for overriding one is identified.
(not referring to submit, which is clearly overridden at least within this plugin, and also in branch-api)
There was a problem hiding this comment.
Does not seem necessary for this PR.
Well, no IMO, the PR is introducing new externally-visible API signatures which are not expected to ever be used externally, so it is related. Not blocking. |
|
But they are only being introduced where there were existing externally-visible API signatures for the old EE 8 types. In other words, the fact that methods were exposed but unused before this PR was just technical debt, which I am not making worse in this PR (but also not making any better). |
See jenkinsci/jenkins#9672.
Testing done
branch-apiandmatrix-authbefore and after migrating those plugins to EE 9