Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of deprecated ANTLRException #241

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Remove usages of deprecated ANTLRException #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@
<properties>
<changelist>999999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/configurationslicing-plugin</gitHubRepo>
<jenkins.version>2.401.3</jenkins.version>
<jenkins.version>2.426.3</jenkins.version>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.401.x</artifactId>
<version>2745.vc7b_fe4c876fa_</version>
<artifactId>bom-2.426.x</artifactId>
<version>2839.v003b_4d9d24fd</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import java.util.Collections;
import java.util.List;

import antlr.ANTLRException;
import configurationslicing.TopLevelItemSelector;
import configurationslicing.UnorderedStringSlicer.UnorderedStringSlicerSpec;

Expand Down Expand Up @@ -54,7 +53,7 @@ public List<Job> getWorkDomain() {
return TopLevelItemSelector.getAllTopLevelItems(Job.class);
}

public abstract Trigger newTrigger(String spec, Trigger oldTrigger) throws ANTLRException;
public abstract Trigger newTrigger(String spec, Trigger oldTrigger);

public boolean setValues(Job item, List<String> set) {
if (set.isEmpty())
Expand Down Expand Up @@ -90,7 +89,7 @@ public boolean setValues(Job item, List<String> set) {
newtrigger.start(item, true);
}
return true;
} catch (ANTLRException e) {
} catch (IllegalArgumentException e) {
// need to log this
return false;
} catch (IOException e) {
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/configurationslicing/timer/SCMTimerSliceStringSlicer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import hudson.model.Job;
import hudson.triggers.SCMTrigger;
import hudson.triggers.Trigger;
import antlr.ANTLRException;
import configurationslicing.UnorderedStringSlicer;

@Extension
Expand All @@ -29,7 +28,7 @@ public String getUrl() {
}

@SuppressWarnings("unchecked")
public Trigger newTrigger(String spec, Trigger oldTrigger) throws ANTLRException {
public Trigger newTrigger(String spec, Trigger oldTrigger) {
boolean ignorePostCommitHooks = false;
if(oldTrigger instanceof SCMTrigger) {
ignorePostCommitHooks = ((SCMTrigger)oldTrigger).isIgnorePostCommitHooks();
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/configurationslicing/timer/TimerSliceStringSlicer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import hudson.model.Job;
import hudson.triggers.TimerTrigger;
import hudson.triggers.Trigger;
import antlr.ANTLRException;
import configurationslicing.UnorderedStringSlicer;

@Extension
Expand All @@ -29,7 +28,7 @@ public String getUrl() {
}

@SuppressWarnings("unchecked")
public Trigger newTrigger(String spec, Trigger oldTrigger) throws ANTLRException {
public Trigger newTrigger(String spec, Trigger oldTrigger) {
return new TimerTrigger(spec);
}

Expand Down