chore: Prepare for sunset icon removal from core

[NotMyFault]

Preparation for core sunsetting dated icons: https://github.com/jenkinsci/jenkins/pull/5778

@guysoft Would be nice if you can also trigger a release after merging this PR. The core PR is blocked until then.
Thanks in advance!

[guysoft]

Cool can do that. PR looks good too

[guysoft]

I am stuck though making a new release because the pom.xml has to be changed according to this format:
https://www.jenkins.io/doc/developer/plugin-development/updating-parent/

Does anyone know if there is some script that would update this?

[NotMyFault]

The pom looks good, you have a parent set and a properties tag for the plugin baseline.

Though to note, I'm more used to releasing via CD and incrementals.

[guysoft]

I am getting this when I try to release, if you have any insight, I am not that exprneinced in this 😊

Ran:

ARTIFACTORY_USERNAME=guysoft JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64 mvn release:prepare release:perform

got:

[INFO] Scanning for projects...
Downloading from repo.jenkins-ci.org: http://repo.jenkins-ci.org/public/org/jenkins-ci/plugins/plugin/4.25/plugin-4.25.pom
Downloading from central: https://repo.maven.apache.org/maven2/org/jenkins-ci/plugins/plugin/4.25/plugin-4.25.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for org.jenkins-ci.plugins:configurationslicing:${revision}${changelist}: Could not transfer artifact org.jenkins-ci.plugins:plugin:pom:4.25 from/to repo.jenkins-ci.org (http://repo.jenkins-ci.org/public/): Transfer failed for http://repo.jenkins-ci.org/public/org/jenkins-ci/plugins/plugin/4.25/plugin-4.25.pom 308 Permanent Redirect and 'parent.relativePath' points at no local POM @ line 3, column 10
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.jenkins-ci.plugins:configurationslicing:${revision}${changelist} (/home/guy/workspace/configurationslicing-plugin/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for org.jenkins-ci.plugins:configurationslicing:${revision}${changelist}: Could not transfer artifact org.jenkins-ci.plugins:plugin:pom:4.25 from/to repo.jenkins-ci.org (http://repo.jenkins-ci.org/public/): Transfer failed for http://repo.jenkins-ci.org/public/org/jenkins-ci/plugins/plugin/4.25/plugin-4.25.pom 308 Permanent Redirect and 'parent.relativePath' points at no local POM @ line 3, column 10 -> [Help 2]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

[NotMyFault]

Non-resolvable parent POM for org.jenkins-ci.plugins:configurationslicing:${revision}${changelist}:

Did you change

<version>${revision}${changelist}</version>
<tag>${scmTag}</tag>

to

<version>1.53</version>
<tag>1.53</tag>

?

[guysoft]

Ok that works, but I can't push stuff to http://repo.jenkins-ci.org/public/ now, nor can I reset my password (user has no permissions to reset password) :-/
@oleg-nenashev any idea how to fix that?

[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for org.jenkins-ci.plugins:configurationslicing:1.53: Could not transfer artifact org.jenkins-ci.plugins:plugin:pom:4.25 from/to repo.jenkins-ci.org (http://repo.jenkins-ci.org/public/): Transfer failed for http://repo.jenkins-ci.org/public/org/jenkins-ci/plugins/plugin/4.25/plugin-4.25.pom 308 Permanent Redirect and 'parent.relativePath' points at no local POM @ line 3, column 10
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.jenkins-ci.plugins:configurationslicing:1.53 (/home/guy/workspace/configurationslicing-plugin/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for org.jenkins-ci.plugins:configurationslicing:1.53: Could not transfer artifact org.jenkins-ci.plugins:plugin:pom:4.25 from/to repo.jenkins-ci.org (http://repo.jenkins-ci.org/public/): Transfer failed for http://repo.jenkins-ci.org/public/org/jenkins-ci/plugins/plugin/4.25/plugin-4.25.pom 308 Permanent Redirect and 'parent.relativePath' points at no local POM @ line 3, column 10 -> [Help 2]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

[NotMyFault]

Hm weird, I changed to deploying via CD considering I find it more convenient, but according to the RPU you have permission.
@timja Do you mind taking a look if you get the chance to? 👀

[timja]

not sure from a quick look

[guysoft]

@NotMyFault How do you use CD to release?
I can see the build has results here, but I am not sure how to deploy from there:
https://ci.jenkins.io/job/Plugins/job/configurationslicing-plugin/job/master/

[timja]

https://www.jenkins.io/doc/developer/publishing/releasing-cd/

[guysoft]

Where does that go?
Its part of github actions or something in the Jenkinsfile?

cd:
  enabled: true

[NotMyFault]

Where does that go? Its part of github actions or something in the Jenkinsfile?

cd:
  enabled: true

File a PR against the RPU for your plugin-configurationslicing.yml file.
Someone from the infra team needs to initially set it up for you.
If you find the tokens in https://github.com/jenkinsci/configurationslicing-plugin/settings/secrets/actions you can copy/paste the files from "Adding the GitHub actions"

[timja]

Someone from the infra team needs to initially set it up for you.

It's automatically done by RPU when cd.enabled = true is set