[JENKINS-49101] Whitelist Gherkin model classes used during Remoting #12
Conversation
| @@ -0,0 +1 @@ | |||
| buildPlugin(jenkinsVersions: [null, '2.103']) | |||
There was a problem hiding this comment.
CucumberJSONSupportPluginIT.testSerializationOnSlave did its job; keep on running it!
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>scm-api</artifactId> | ||
| <version>1.2</version> |
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>credentials</artifactId> | ||
| <version>1.18</version> |
There was a problem hiding this comment.
Similar, though from InjectedTest—optional deps do not currently get processed. (Cf. jenkinsci/maven-plugin#105 (comment).)
| @@ -135,7 +134,7 @@ public void perform(Run<?, ?> run, FilePath filePath, Launcher launcher, TaskLis | |||
| CucumberTestResult result = parser.parseResult(_testResults, build, workspace, launcher, listener); | |||
|
|
|||
| // TODO - look at all of the Scenarios and see if there are any embedded items contained with in them | |||
| String remoteTempDir = launcher.getChannel().call(new TmpDirCallable()); | |||
| String remoteTempDir = workspace.act(new TmpDirCallable()); | |||
There was a problem hiding this comment.
FindBugs: getChannel could be null. Anyway FilePath.act is simpler.
| @@ -144,7 +143,7 @@ public void perform(Run<?, ?> run, FilePath filePath, Launcher launcher, TaskLis | |||
| // this is the wrong place to do the copying... | |||
| // XXX Need to do something with MasterToSlaveCallable to makesure we are safe from evil | |||
| // injection | |||
| FilePath srcFilePath = new FilePath(launcher.getChannel(), remoteTempDir + '/' + item.getFilename()); | |||
| FilePath srcFilePath = new FilePath(workspace, remoteTempDir + '/' + item.getFilename()); | |||
There was a problem hiding this comment.
Not necessary, but simplifying while we are here.
| @@ -0,0 +1,19 @@ | |||
| gherkin.formatter.Mappable | |||
There was a problem hiding this comment.
About half of these are reproducible from the functional test. The rest were added by code inspection of the Gherkin library; presumably a more complete passWithEmbeddedItem.json would be able to reproduce the full spectrum.
|
Thanks @jglick |
JENKINS-49101
@reviewbybees