Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable built-in auto-save functionality of DataTables #356

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented May 22, 2023

Do not use custom serialization anymore when Prototype is not loaded. The new feature requires Jenkins 2.406 or newer. For older versions, the old custom serialization is used.

Do not use custom serialization anymore when Prototype is not loaded.
Requires Jenkins 2.406 or newer.
@uhafner uhafner added the internal Internal changes without user or API impact label May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #356 (c7c15cf) into master (831d74b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #356   +/-   ##
=========================================
  Coverage     73.93%   73.93%           
  Complexity       22       22           
=========================================
  Files             5        5           
  Lines           165      165           
  Branches          6        6           
=========================================
  Hits            122      122           
  Misses           43       43           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner requested a review from mPokornyETM May 22, 2023 19:28
@mPokornyETM
Copy link
Contributor

@uhafner Thx to add me as review. That means I can remove the option 'data-remember-search-text="true"' in lockable-resources-plugin as well. I am not fit with JavaScript, therefore can not really review the changes. Let me test it if it works in my local build and then LGTM ;-)

@uhafner
Copy link
Member Author

uhafner commented May 23, 2023

@uhafner Thx to add me as review.

It is more meant as FYI.

That means I can remove the option 'data-remember-search-text="true"' in lockable-resources-plugin as well.

Not yet. When I bring this change into production we need to wait until all older Jenkins versions are not supported anymore (will require > one year)...

@uhafner uhafner merged commit dd94396 into master Jun 1, 2023
@uhafner uhafner deleted the no-prototype branch June 1, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants