Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive test suite on Windows #331

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Revive test suite on Windows #331

merged 1 commit into from
Jan 20, 2025

Conversation

basil
Copy link
Member

@basil basil commented Jan 18, 2025

No description provided.

@dduportal
Copy link

The test Harness seems to assume that Docker on Windows only runs Linux containers while our VM agents, today, are only providing Windows containers on Windows VMs. So it errors with a message such as docker: no matching manifest for windows/amd64 10.0.17763 in the manifest list entries.. For instance httpd or maven official Docker images.

It also fails for the SCRATCH image which does not exist on Windows.

@jtnord did already open an issue to request having a Docker Engine able to run Linux containers on Windows agents: jenkins-infra/helpdesk#3548

=> Is this a case we want to support with this plugin? It would mean supporting Windows agents with Docker Desktop on them, running in "Linux mode" (which is the default case for developer Windows machines with WSL usually, but is it for Jenkins agents?)

@MarkRx
Copy link
Contributor

MarkRx commented Jan 20, 2025

@dduportal I actually just added to support checking the docker OS mode as a necessity in this in a PR I pushed up here.

See #332

@basil basil force-pushed the windows branch 2 times, most recently from 275847b to 9ef5e52 Compare January 20, 2025 18:57
@basil basil marked this pull request as ready for review January 20, 2025 19:12
@basil basil merged commit 98addf9 into jenkinsci:master Jan 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants