-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-64581] Middle-click or Ctrl+click a build in a trend chart to open the build in a new tab. #381
base: main
Are you sure you want to change the base?
Conversation
Hello @uhafner here is the draft PR |
src/main/webapp/js/echarts-api.js
Outdated
if (event.ctrlKey || event.which === 2) { // Ctrl+Click or Middle-click | ||
window.open(url, '_blank'); // Open in new tab/window | ||
} else if (event.shiftKey) { // Shift+Click | ||
window.open(url, '_blank', 'noopener,noreferrer'); // Open in a new window (more isolated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of "noopener,noreferrer" here? Those would usually be for security isolation between web sites, but the link is to the same Jenkins controller anyway.
…Shift+Click behavior
@KalleOlaviNiemitalo I removed "noopener, noreferrer" parameters since they are not needed for internal Jenkins Navigation. Please verify the changes. |
Hello @uhafner can you review the changes ? |
Did you manage to test it in a chart within Jenkins yet? |
No... I can't manage to test it in a chart within Jenkins using Docker. Still it is showing same error. |
Then it does not make sense to check the "test" task in the description 👎 |
I will deploy the PR into my instance and try to verify the fix... |
Hello @uhafner were you able to deploy the PR on your instance? |
Yes, but it does not work. It fails at:
It also pop ups a menu rather than to open a page. But I have a MacBook without a mouse. I think it is required that you are testing this fix on your machine first! |
Why did you not follow the additional steps in the chat? |
Added standard browser features like Ctrl+Click (open in the new tab), Shift+Click (open in the new window), and right-click context menus to navigate to a build's warning page.
Testing done
Submitter checklist