Filter to the minimal required dependencies for REST/HTTP usage #6
Conversation
| <!-- provided by core --> | ||
| <exclusion> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> |
There was a problem hiding this comment.
No strong opinion on that as both solutions have pros and cons, but I suggest to follow the approach already in place in other Google plugins. So my proposal to use Guava from core.
There was a problem hiding this comment.
if you exclude guava here and the sdk requires a higher version you will not get a enforcer upper-bounds error when bumping. so you would need to check on each and every update to the library proposed by dependabot.
Whilst this is fine - you should leave a comment on the dependency so it is not forgotten (same for all others).
| <!-- provided by core --> | ||
| <exclusion> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> |
There was a problem hiding this comment.
if you exclude guava here and the sdk requires a higher version you will not get a enforcer upper-bounds error when bumping. so you would need to check on each and every update to the library proposed by dependabot.
Whilst this is fine - you should leave a comment on the dependency so it is not forgotten (same for all others).
gcp-java-sdk-storage/pom.xml
Outdated
| <exclusions> | ||
|
|
||
| <!-- use plugin dependency instead --> | ||
| <exclusion> |
There was a problem hiding this comment.
if this is excluded - you will not get an upper-bounds error. rather add this dependency before the google-cloud-one.
note this will likely break spotless - but dependency order probably does matter here (as the depth would be the same unclear if maven-hpi will take it from the plugin or not - probably falls back to first definition - check)!
aneveux
added
the
developer
This excludes all dependencies that not used while using REST/HTTP mode.
Testing done
Submitter checklist