Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send jenkins events async #4

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Send jenkins events async #4

merged 7 commits into from
Jul 26, 2022

Conversation

nikitakasatkin44
Copy link
Contributor

@nikitakasatkin44 nikitakasatkin44 commented Jul 25, 2022

Synchronous http event sending replaced by the async implementation, providing non-blocking way to communite between jenkins and 3rd-party endpoints.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@nikitakasatkin44 nikitakasatkin44 marked this pull request as ready for review July 25, 2022 13:40
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nikitakasatkin44 , thanks for your first contribution. I left some comments below, please take a look at them.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

This feature works well. Please see:

2022-07-26 02:17:47.910+0000 [id=113]	INFO	i.j.p.g.event.HttpEventSender#send: StopWatch 'EventSend': running time = 14997920 ns
---------------------------------------------
ns         %     Task name
---------------------------------------------
014997920  100%  run.initialize

2022-07-26 02:17:47.915+0000 [id=113]	INFO	i.j.p.g.event.HttpEventSender#send: StopWatch 'EventSend': running time = 2877522 ns
---------------------------------------------
ns         %     Task name
---------------------------------------------
002877522  100%  run.started

2022-07-26 02:17:48.351+0000 [id=123]	INFO	o.j.p.workflow.job.WorkflowRun#finish: demo #6 completed: SUCCESS
2022-07-26 02:17:48.353+0000 [id=123]	INFO	i.j.p.g.event.HttpEventSender#send: StopWatch 'EventSend': running time = 1927291 ns
---------------------------------------------
ns         %     Task name
---------------------------------------------
001927291  100%  run.completed

2022-07-26 02:17:48.374+0000 [id=123]	INFO	i.j.p.g.event.HttpEventSender#send: StopWatch 'EventSend': running time = 2314378 ns
---------------------------------------------
ns         %     Task name
---------------------------------------------
002314378  100%  run.finalized

2022-07-26 02:17:48.917+0000 [id=66]	INFO	i.j.p.g.event.HttpEventSender$1#completed: Event send succeeded, response: Event received. Have a nice day.
2022-07-26 02:17:49.918+0000 [id=66]	INFO	i.j.p.g.event.HttpEventSender$1#completed: Event send succeeded, response: Event received. Have a nice day.
2022-07-26 02:17:50.921+0000 [id=66]	INFO	i.j.p.g.event.HttpEventSender$1#completed: Event send succeeded, response: Event received. Have a nice day.
2022-07-26 02:17:51.924+0000 [id=66]	INFO	i.j.p.g.event.HttpEventSender$1#completed: Event send succeeded, response: Event received. Have a nice day.

I simulated the response with 1 second delay.

@nikitakasatkin44
Copy link
Contributor Author

Good day @JohnNiang !
Please tell about current forkflow. Should someone manually merge the approved branch, or it is an automated process, and all we can do is wait?
Task seems to be stuck at phase #2
image

https://github.com/jenkinsci/generic-event-plugin/pulls

@JohnNiang JohnNiang merged commit 5123e60 into jenkinsci:main Jul 26, 2022
@JohnNiang JohnNiang added the enhancement New feature or request label Jul 26, 2022
@ant1dot
Copy link

ant1dot commented Aug 1, 2022

When will this be released?

@JohnNiang
Copy link
Member

When will this be released?

Thank you for your reminder.

I will release a new version containing this feature in the near future.

@ant1dot
Copy link

ant1dot commented Aug 8, 2022

Hello, will there be a release?

@JohnNiang
Copy link
Member

Hello, will there be a release?

Sorry for the delay. I'm in progress on CD automatically recently.

@JohnNiang
Copy link
Member

Hello, will there be a release?

Hi @ant1dot , I'm trying to figure out automated plugin release at #5, please help us review it.

@ant1dot
Copy link

ant1dot commented Aug 11, 2022

can not find node with label in jenkins: All nodes of label ‘maven-windows’ are offline
https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgeneric-event-plugin/detail/PR-5/1/pipeline

@JohnNiang
Copy link
Member

@ant1dot
Copy link

ant1dot commented Aug 11, 2022

Hi @ant1dot , please check the latest release: https://github.com/jenkinsci/generic-event-plugin/releases/tag/38.v3c1b96fab48f

thank you very much, we will install and test it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants