-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send jenkins events async #4
Send jenkins events async #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nikitakasatkin44 , thanks for your first contribution. I left some comments below, please take a look at them.
src/main/java/io/jenkins/plugins/generic/event/HttpEventSender.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/generic/event/HttpEventSender.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
This feature works well. Please see:
2022-07-26 02:17:47.910+0000 [id=113] INFO i.j.p.g.event.HttpEventSender#send: StopWatch 'EventSend': running time = 14997920 ns
---------------------------------------------
ns % Task name
---------------------------------------------
014997920 100% run.initialize
2022-07-26 02:17:47.915+0000 [id=113] INFO i.j.p.g.event.HttpEventSender#send: StopWatch 'EventSend': running time = 2877522 ns
---------------------------------------------
ns % Task name
---------------------------------------------
002877522 100% run.started
2022-07-26 02:17:48.351+0000 [id=123] INFO o.j.p.workflow.job.WorkflowRun#finish: demo #6 completed: SUCCESS
2022-07-26 02:17:48.353+0000 [id=123] INFO i.j.p.g.event.HttpEventSender#send: StopWatch 'EventSend': running time = 1927291 ns
---------------------------------------------
ns % Task name
---------------------------------------------
001927291 100% run.completed
2022-07-26 02:17:48.374+0000 [id=123] INFO i.j.p.g.event.HttpEventSender#send: StopWatch 'EventSend': running time = 2314378 ns
---------------------------------------------
ns % Task name
---------------------------------------------
002314378 100% run.finalized
2022-07-26 02:17:48.917+0000 [id=66] INFO i.j.p.g.event.HttpEventSender$1#completed: Event send succeeded, response: Event received. Have a nice day.
2022-07-26 02:17:49.918+0000 [id=66] INFO i.j.p.g.event.HttpEventSender$1#completed: Event send succeeded, response: Event received. Have a nice day.
2022-07-26 02:17:50.921+0000 [id=66] INFO i.j.p.g.event.HttpEventSender$1#completed: Event send succeeded, response: Event received. Have a nice day.
2022-07-26 02:17:51.924+0000 [id=66] INFO i.j.p.g.event.HttpEventSender$1#completed: Event send succeeded, response: Event received. Have a nice day.
I simulated the response with 1 second delay.
Good day @JohnNiang ! |
When will this be released? |
Thank you for your reminder. I will release a new version containing this feature in the near future. |
Hello, will there be a release? |
Sorry for the delay. I'm in progress on CD automatically recently. |
can not find node with label in jenkins: All nodes of label ‘maven-windows’ are offline |
Hi @ant1dot , please check the latest release: https://github.com/jenkinsci/generic-event-plugin/releases/tag/38.v3c1b96fab48f |
thank you very much, we will install and test it soon |
Synchronous http event sending replaced by the async implementation, providing non-blocking way to communite between jenkins and 3rd-party endpoints.