Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-21520] transient NoClassDefFoundError: javax/servlet/ServletException #171

Merged
merged 1 commit into from
Jul 10, 2015

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jul 9, 2015

No description provided.

@ndeloof
Copy link
Contributor Author

ndeloof commented Jul 9, 2015

Not sure why having a reference to Functions do drag some unexpected classes on slave then breaks ClassLoading, anyway inlining this on-line functions seems a reasonable workaround
@reviewbybees

@ghost
Copy link

ghost commented Jul 9, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@MarkEWaite
Copy link
Contributor

Doesn't the reference also need to be removed from src/main/java/hudson/plugins/git/GitTool.java?

Shouldn't it also be removed from src/test/java/org/jenkinsci/plugins/gitclient/WarnTempDirValueTest.java to reduce the risk that someone will see its use in a test and introduce it back into the main code?

@ndeloof
Copy link
Contributor Author

ndeloof commented Jul 9, 2015

makes sense indeed

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@stephenc
Copy link
Member

🐝

MarkEWaite added a commit that referenced this pull request Jul 10, 2015
[JENKINS-21520] transient NoClassDefFoundError: javax/servlet/ServletException
@MarkEWaite MarkEWaite merged commit 0b57fec into jenkinsci:master Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants