[JENKINS-64712] Fix unexpected scrolling of config UI #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the GitTool data model has the useExistingAccountWithSameEmail and the useExistingAccountWithSameEmail fields at the same level, this simplifies the user experience by displaying them both at the time. Existing values are loaded as expected on startup. Values are persisted to the GitTool.xml configuration file when the configuration is applied or saved. Appears to be purely a presentation convenience to only show the useExistingAccountWithSameEmail if the useExistingAccountWithSameEmail checkbox was enabled. Tested interactively with Jenkins 2.263.4, Jenkins 2.277.1-rc, and Jenkins 2.281. Behaves as expected in all cases. Hints in other communities suggest that the unexpected scrolling is caused by specific CSS markup, but I can't find that specific markup in my search of the generated page. Rather than fight with CSS markup, it is easier to move the nested checkbox to the top level.
No benefit to retaining that UI code when it hasn't been tested or maintained since it was disabled 7 years ago.
|
@MRamonLeon I merged it on the assumption that my interactive testing was sufficient and you likely don't have time to review the code. |
|
Sorry for the late response, I was looking into it and the changes are sensible to me. But I wondered if with the new changes, we were sending data that we were not previously (the nested field). I looked into the Just as I mentioned, your reasoning seems fine to me. |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-64712 - Fix unexpected scrolling of nested checkbox
The nesting of one checkbox beneath another checkbox appears to be purely a presentation convenience to only show the
useExistingAccountWithSameEmailif theuseExistingAccountWithSameEmailcheckbox was enabled. Since the GitTool data model has theuseExistingAccountWithSameEmailand theuseExistingAccountWithSameEmailfields at the same level, this simplifies the user experience by displaying them both at the time.Tested interactively with Jenkins 2.263.4, Jenkins 2.277.1-rc, and Jenkins 2.281. Behaves as expected in all cases.
Checklist
Types of changes
Further comments
Existing values are loaded as expected on startup.
Values are persisted to the GitTool.xml configuration file when the configuration is applied or saved.
Hints in other communities suggest that the unexpected scrolling is caused by specific CSS markup, but I can't find that specific markup in my search of the generated page. Rather than fight with CSS markup, it is easier to move the nested checkbox to the top level.
Would love to have review and verification by @MRamonLeon