Support for Gitorious repositories #38
Conversation
| public URL getDiffLink(Path path) throws IOException { | ||
| final GitChangeSet changeSet = path.getChangeSet(); | ||
| // gitorious does not show diffs on single files so we create a link to the commit | ||
| return new URL(url, "commit/" + changeSet.getId().toString()); |
There was a problem hiding this comment.
Hello Kraig,
I see there is no method to jump directly to a specific file in the inline view, however something like:
https://gitorious.org/jenkinsci/jenkins/commit/bf2f214983517bc1656fa560e50e5e4df84eba95/diffs?diffmode=sidebyside&fragment=1#test/src/test/java/hudson/tasks/junit/TestResultTest.java
does work, so maybe changing this would be good.
`return new URL(url, "commit/" + changeSet.getId().toString() + "/diffs?diffmode=sidebyside&fragment=1#" + path);``
Regards
Mirko
|
Thanks Mirko, how is that? |
|
Strange enough, neither on http://huschteguzzel.de/hudson/job/jenkinsci-git-plugin/org.jenkinsci.plugins$git/484/testReport/ the master does build without test failures nor on my local machine. Do the tests run fine on your machine? |
|
Master built cleanly on my Mac, so maybe this is due to older versions of git on the other machines. Pulled your request, built flawlessly. I will try it in huschteguzzel. |
|
Links work successfully, now merging. |
|
Merged and pushed to master, automatic merge was still referencing old commit 5706ede, so merge was done manually. |
Adds support for generate links for Gitorious repositories.