Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71922] Support Java 21 #184

Merged
merged 3 commits into from
Sep 11, 2023
Merged

[JENKINS-71922] Support Java 21 #184

merged 3 commits into from
Sep 11, 2023

Conversation

alecharp
Copy link
Member

@alecharp alecharp commented Sep 6, 2023

Related to JENKINS-71922

The usage of Lombok was introduced in 5972f75.
The dependency was used only to remove a few lines of code which can generally be generated by any IDE.

There is no usages of the library outside of the CredentialsListBoxModel class, so it seems a bit overkill to use the library. Removing it to be compatible with Java 21 seems quicker.

Testing done

Ran mvn verify with Java 21, no issue.
Ran mvn hpi:run using Java 21 but faced issue when trying to use the plugin in Google Compute Engine where creating a compute-engine node in Jenkins yields an issue about not finding configure-entries.jelly for ComputeEngineInstance class.

Submitter checklist

Preview Give feedback

@alecharp
Copy link
Member Author

alecharp commented Sep 6, 2023

To be useful, the PR should be reopened by a maintainer or an admin so that the Jenkinsfile is used.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replayed the run with Jenkinsfile changes here:

https://ci.jenkins.io/job/Plugins/job/google-oauth-plugin/job/PR-184/3/

Build is green

@alecharp alecharp marked this pull request as ready for review September 7, 2023 08:40
@alecharp
Copy link
Member Author

@jenkinsci/google-oauth-plugin-developers do you think this could be merged and released?

@jtnord jtnord merged commit c7b56f0 into jenkinsci:develop Sep 11, 2023
@jtnord
Copy link
Member

jtnord commented Sep 11, 2023

https://github.com/jenkinsci/google-oauth-plugin/releases/tag/google-oauth-plugin-1.0.11

@alecharp alecharp deleted the feature/removes-lombok-dependency branch September 11, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants