Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 1 unnecessary stubbing in P12ServiceAccountConfigTest.java #192

Merged

Conversation

ARUS2023
Copy link
Contributor

Testing done

Submitter checklist

Preview Give feedback

In our analysis of the project, we observed that the test P12ServiceAccountConfigTest.testCreateWithEmptyP12KeyFile contains 1 unnecessary stubbing.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbing.

@rsandell rsandell added the tests label Oct 4, 2023
@rsandell rsandell merged commit 2a344d9 into jenkinsci:develop Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants