Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a validation for the required email field in p12 credentials form #208

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

aneveux
Copy link
Member

@aneveux aneveux commented Dec 5, 2023

Hello 👋

While creating a credential using a p12 key, there is no validation of the email field while it should actually be required.

This PR adds a simple form validation adding an error message when no value is specified for the email address.

Here is how the validation looks:

Validation Failure

image

Validation Success

image

The feature was tested manually using mvn hpi:run.

Testing done

Submitter checklist

Preview Give feedback

@@ -222,6 +225,16 @@ private KeyStore getP12KeyStore()
/** Descriptor for P12 service account authentication. */
@Extension
public static final class DescriptorImpl extends Descriptor {

@POST
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overkill IMO, but ok

Copy link
Member

@amuniz amuniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olamy olamy merged commit 9dce44d into jenkinsci:develop Dec 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants