Require Java 11, test with Java 21 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21. The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21. The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is low. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
|
@ikedam I'd appreciate it very much if you would merge this pull request so that the plugin is tested regularly with Java 21. No need for a release, just a merge. |
MarkEWaite
added a commit
to MarkEWaite/repository-permissions-updater
that referenced
this pull request
Dec 15, 2023
jenkinsci/groovy-postbuild-plugin#56 is the pull request that I would like to merge. I use the groovy postbuild plugin in my test environment and would like to assure that it is regularly built and tested with Java 21. The proposed pull request will close several other pending pull requests and simplify the maintenance of the plugin. @ikedam as the sole maintainer of the plugin, would you approve me being added as a maintainer? If there is no response from @ikedam, I'm happy to wait the two weeks for the adoption request to be active.
MarkEWaite
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require Java 11, test with Java 21
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is low. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
Replaces pull requests:
Testing done
Confirmed that tests pass with Java 21 on Linux.
Submitter checklist