This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Suppress spotbugs PA_PUBLIC_PRIMITIVE_ATTRIBUTE warnings #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.jenkins.io/doc/developer/tutorial-improve/add-more-spotbugs-checks/ describes the technique used here with an exclusions file. The specific exclusion for PA_PUBLIC_PRIMITIVE_ATTRIBUTE has been confirmed by Jenkins developers that it is not helpful in a Jenkins plugin. jenkinsci/jenkins#8803 describes the changes that were made in Jenkins core and in many Jenkins plugins to suppress the PA_PUBLIC_PRIMITIVE_ATTRIBUTE spotbugs warning.
|
@centic9 this will fix the build on the master branch. It will also unblock: |
|
Closing in favor of: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress spotbugs PA_PUBLIC_PRIMITIVE_ATTRIBUTE warnings
The improve a plugin tutorial describes the technique used here with an exclusions file. The specific exclusion for PA_PUBLIC_PRIMITIVE_ATTRIBUTE has been confirmed by Jenkins developers that it is not helpful in a Jenkins plugin.
Jenkins core PR-8803 describes the changes that were made in Jenkins core and in many Jenkins plugins to suppress the PA_PUBLIC_PRIMITIVE_ATTRIBUTE spotbugs warning.
Testing done
Confirmed that spotbugs warnings are visible before this change and are resolved after this change. No change to Java source code or the pom file. Uses the default location of the spotbugs suppression file from the parent pom.
Submitter checklist