Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern color function notation #10080

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 19, 2024

Investigating if we can use modern color function notation rather than the legacy. Want to make sure HTMLUnit/ATH is happy with it.

Testing done

  • Tests pass
  • BOM passes

Proposed changelog entries

  • human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@timja
Copy link
Member

timja commented Jan 1, 2025

If you want to go ahead with this can you run through a bom build please?

@timja timja added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog labels Jan 3, 2025
@janfaracik janfaracik marked this pull request as ready for review January 3, 2025 16:50
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja added the pct-successful This PR has successfully passed the full plugin-compatibility-test suite label Jan 3, 2025
@timja timja requested a review from a team January 3, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pct-successful This PR has successfully passed the full plugin-compatibility-test suite skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants