[JENKINS-74868] Use new build status symbols in multi branch projects #10106

timja · 2024-12-30T22:24:40Z

Fixes jenkinsci/dark-theme-plugin#550
Closes jenkinsci/dark-theme-plugin#552
Closes #10032

Review with whitespace disabled: https://github.com/jenkinsci/jenkins/pull/10106/files?w=1

Testing done

Created a multi branch project
Configured with single repository and branch using https://github.com/timja-org/junit-attachments-test
Ran a build and aborted it before it got anywhere

Before it was using the old symbol which looked bad in dark theme and was inconsistent

After:

I've also tested with custom-job-folder-icon and a variety of folder and non folder jobs I have in my setup.

Proposed changelog entries

Use refined build status icons in multi-branch projects

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

timja · 2024-12-30T22:25:24Z

cc @Jonny-vb

krisstern · 2024-12-30T22:36:40Z

Agreeing that this may be a better approach

timja · 2024-12-30T23:21:40Z

core/src/main/resources/lib/hudson/ballColorTd.jelly

-    <st:attribute name="it" type="hudson.model.BallColor">
-      Color of the ball or null to skip drawing.
+    Display the build status icon in a table cell.
+    <st:attribute name="it" type="hudson.model.StatusIcon">


in reality what is passed is not a ballcolor in many cases but actually a status icon

timja · 2024-12-30T23:21:55Z

core/src/main/resources/lib/hudson/ballColorTd.jelly

-      Color of the ball or null to skip drawing.
+    Display the build status icon in a table cell.
+    <st:attribute name="it" type="hudson.model.StatusIcon">
+      Icon to be displayed.


balls are not displayed anymore, small cleanup

janfaracik · 2024-12-31T11:00:31Z

Tested locally, LGTM!

krisstern

LGTM too

timja · 2025-01-02T07:46:57Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

commit 76d4bb8 Author: Jan Faracik <[email protected]> Date: Sun Jan 5 11:01:47 2025 +0000 Fix in case of null provider commit ebb6831 Author: Jan Faracik <[email protected]> Date: Sat Jan 4 15:23:03 2025 +0000 Lint commit 11e4b8d Author: Jan Faracik <[email protected]> Date: Sat Jan 4 14:48:20 2025 +0000 Init commit 519eb19 Merge: 908030e b3b5a69 Author: Kris Stern <[email protected]> Date: Sat Jan 4 16:01:19 2025 +0800 Merge pull request jenkinsci#9980 from basil/OptionHandlerExtension Register `OptionHandler`s through `META-INF/services/annotations` and Annotation Indexer rather than `META-INF/services` and Commons Discovery commit 908030e Merge: d3e8908 fc4a567 Author: Kris Stern <[email protected]> Date: Sat Jan 4 16:00:31 2025 +0800 Merge pull request jenkinsci#10026 from mtughan/allow-immutable-collections Allow all immutable List subclasses from Java 11 commit d3e8908 Author: Jesse Glick <[email protected]> Date: Fri Jan 3 05:43:27 2025 -0500 Correcting API documentation of `builds` vs. `allBuilds` (jenkinsci#10112) commit 89f48c5 Merge: 238c498 e1dff1a Author: Kris Stern <[email protected]> Date: Fri Jan 3 18:00:18 2025 +0800 Merge pull request jenkinsci#10106 from timja/ballColorTd-table [JENKINS-74868] Use new build status symbols in multi branch projects commit 238c498 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Jan 2 20:32:04 2025 -0800 Update dependency io.jenkins.plugins:design-library to v342 (jenkinsci#10111) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 75410bc Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Jan 2 10:45:55 2025 -0800 Update dependency io.jenkins.plugins:json-api to v20241224 (jenkinsci#10110) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 1aa9c57 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Jan 2 10:44:50 2025 -0800 Update Yarn to v4.6.0 (jenkinsci#10109) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit e1dff1a Author: Tim Jacomb <[email protected]> Date: Tue Dec 31 19:46:12 2024 +0000 Adjust test commit 5fd9f51 Author: Tim Jacomb <[email protected]> Date: Mon Dec 30 22:20:15 2024 +0000 [JENKINS-74868] Use new build status symbols in multi branch projects commit b3b5a69 Merge: 33d8280 d73c0ea Author: Basil Crow <[email protected]> Date: Tue Dec 17 10:19:22 2024 -1000 Merge branch 'master' into OptionHandlerExtension commit fc4a567 Author: Michael Tughan <[email protected]> Date: Wed Dec 4 15:15:13 2024 -0500 Allow all immutable List subclasses from Java 11 A previous commit specifically allowed one of the two subclasses used by `List.of` and `List.copyOf`, but not the other, which can result in unexpected errors and bugs. Add the other to the default allow list of classes to avoid these. commit 33d8280 Merge: a1c8c83 9965f04 Author: Tim Jacomb <[email protected]> Date: Sun Dec 8 08:32:24 2024 +0000 Merge branch 'master' into OptionHandlerExtension commit a1c8c83 Author: Basil Crow <[email protected]> Date: Fri Nov 15 10:58:26 2024 -0800 Register `OptionHandler`s through `META-INF/services/annotations` and Annotation Indexer rather than `META-INF/services` and Commons Discovery

[JENKINS-74868] Use new build status symbols in multi branch projects

5fd9f51

timja added the alternative This PR is one of several options to address a given issue label Dec 30, 2024

timja mentioned this pull request Dec 30, 2024

Make aborted and disabled icon colours themable #10032

Closed

timja added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features labels Dec 30, 2024

timja requested a review from a team December 30, 2024 22:27

timja commented Dec 30, 2024

View reviewed changes

janfaracik approved these changes Dec 31, 2024

View reviewed changes

Adjust test

e1dff1a

timja requested a review from a team December 31, 2024 19:46

krisstern approved these changes Jan 2, 2025

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 2, 2025

krisstern merged commit 89f48c5 into jenkinsci:master Jan 3, 2025
16 checks passed

This was referenced Jan 3, 2025

Change icon colour for disabled pipelines to be more visible jenkinsci/dark-theme-plugin#552

Closed

Disabled Status icon is not visible jenkinsci/dark-theme-plugin#550

Closed

janfaracik mentioned this pull request Jan 7, 2025

[JENKINS-74879] Use strikethrough on merged pull request name column jenkinsci/branch-api-plugin#501

Merged

6 tasks

mawinter69 mentioned this pull request Jan 12, 2025

Updated icon-aborted colors for better visibility. #10145

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-74868] Use new build status symbols in multi branch projects #10106

[JENKINS-74868] Use new build status symbols in multi branch projects #10106

timja commented Dec 30, 2024 •

edited by krisstern

Loading

Submitter checklist

Maintainer checklist

timja commented Dec 30, 2024

krisstern commented Dec 30, 2024

timja Dec 30, 2024

timja Dec 30, 2024

janfaracik commented Dec 31, 2024

krisstern left a comment

timja commented Jan 2, 2025

[JENKINS-74868] Use new build status symbols in multi branch projects #10106

[JENKINS-74868] Use new build status symbols in multi branch projects #10106

Conversation

timja commented Dec 30, 2024 • edited by krisstern Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

timja commented Dec 30, 2024

krisstern commented Dec 30, 2024

timja Dec 30, 2024

Choose a reason for hiding this comment

timja Dec 30, 2024

Choose a reason for hiding this comment

janfaracik commented Dec 31, 2024

krisstern left a comment

Choose a reason for hiding this comment

timja commented Jan 2, 2025

timja commented Dec 30, 2024 •

edited by krisstern

Loading