[JENKINS-19445, JENKINS-34213, JENKINS-34808, JENKINS-34121] Bump remoting to 2.59

[oleg-nenashev]

This pull-request updates remoring in 1.651.x LTS baseline

Why upgrade instead of backporting:

• All changes in 2.58 may be considered as bugs
• Functional logic in JENKINS-19445, JENKINS-34808
• 2.59 change is critical due to known issues in the JNLP3 protocol

Cons: the change has been released in jenkins-2.54 on May 15, so 2 weeks of soaking have not passed yet

Changes:

2.58:

• JENKINS-34213 - Ensure that the unexporter cleans up whatever it can each sweep ([FIXED JENKINS-34213] Ensure that the unexporter cleans up whatever it can each sweep remoting#81)
• JENKINS-19445 Force class load on UserRequest in order to prevent deadlock on windows nodes when using JNA and Subversion (Force class load on UserRequest, see JENKINS-19445 remoting#82)
• JENKINS-34808 - Allow user to adjust socket timeout ([JENKINS-34808] - Allow user to adjust socket timeout remoting#68)

2.59:

• JENKINS-34819 - Allow disabling the remoting protocols individually. Works around issues like JENKINS-34121 ([JENKINS-34819] Allow disabling the protocols individually remoting#83)

@olivergondza @aheritier @stephenc @reviewbybees

[oleg-nenashev]

Off-topic: Seems @kohsuke released 1.651.2 from the parallel universe branch. I have no idea what I actually patch 😨

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[aheritier]

🐝 I'm +1000 to have these fix but less happy to have them bundled with the recent version which proposed JNLP3 protocol by default and which has some known issues :(
But I know that it is hard and cost a lost to create a maintenance branch of remoting which doesn't include JNPL3 :(

[oleg-nenashev]

@aheritier 1.651.x LTS already uses the baseline with JNLP3 by default.
Good news is that it's possible to disable it via system properties with this fix

[stephenc]

🐝

[olivergondza]

👍

[aheritier]

ok cool @oleg-nenashev thus 🐝 🐝 🐝

[oleg-nenashev]

@reviewbybees done

[olivergondza]

Cherrypicked.