Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39971] Always display the recheck button #2668

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

bpedersen2
Copy link
Contributor

@bpedersen2 bpedersen2 commented Dec 16, 2016

The re-check updatecenter button should be visible even if there are
currently no pending updates.

https://issues.jenkins-ci.org/browse/JENKINS-39971

The re-check updatecenter button should be visible even if there are
currently no pending updates.
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me 👍

@daniel-beck
Copy link
Member

Reading the code LGTM as well. Could we get before/after screenshots of an empty/filled table perhaps? But not strictly necessary for this change, I think.

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 16, 2016
@oleg-nenashev oleg-nenashev merged commit 8634965 into jenkinsci:master Dec 16, 2016
olivergondza pushed a commit that referenced this pull request Jan 11, 2017
…er (#2668)

The re-check updatecenter button should be visible even if there are
currently no pending updates.
(cherry picked from commit 8634965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants