[FIX JENKINS-30785] Generalize some CLI stuff to AbstractItem #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
added
the
needs-more-reviews
|
@pjanouse PTAL |
daniel-beck
added
the
needs-comments-resolved
|
grumbles stupid tests… |
| @@ -78,11 +79,10 @@ protected int run() throws Exception { | |||
| } | |||
|
|
|||
| if(job == null) { | |||
| // TODO: JENKINS-30785 | |||
| AbstractProject project = AbstractProject.findNearest(job_s); | |||
| AbstractItem project = Items.findNearest(AbstractItem.class, job_s, jenkins); | |||
| // TODO can this (and its pseudo-override in AbstractProject) share code with GenericItemOptionHandler, used for explicit CLICommand’s rather than CLIMethod’s? | ||
| AbstractItem item = Jenkins.getInstance().getItemByFullName(name, AbstractItem.class); | ||
| if (item==null) { | ||
| AbstractProject project = AbstractProject.findNearest(name); | ||
| AbstractItem project = Items.findNearest(AbstractItem.class, name, Jenkins.getInstance()); |
There was a problem hiding this comment.
Uh. IMHO should be reported as a separate bug
|
Will cover the |
|
Actually nah, I will just merge yours in, looks good to me. |
6 tasks
|
GitHub would have automatically marked this as merged if @oleg-nenashev had not squashed commits, losing history of what was actually included. |
|
@jglick Yes, I caused some mess in this case. squashing was not intentional this time since I didn't want to deal with mess in downstream PRs. But yeah, now it's my responsibility to deal with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-30785