[JENKINS-50969] core site build is broken, needed for core taglibs reference #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batmat
added
the
work-in-progress
batmat
changed the title
batmat
removed
the
work-in-progress
batmat
added
needs-more-reviews
|
Putting this |
…ference The special old module for doxia seems not needed. I suspect that it is because since 2012 when it was released, the Markdown support got done in standard. IIUC this was pulling in some very old doxia versions, which was incompatible with maven-fluido-skin which I needed to bump from current 1.3.0 to 1.7 for https://github.com/jenkins-infra/core-taglibs-report-generator to work again.
batmat
commented
Apr 27, 2018
pom.xml
Outdated
| @@ -28,7 +28,7 @@ THE SOFTWARE. | |||
| <parent> | |||
| <groupId>org.jenkins-ci</groupId> | |||
| <artifactId>jenkins</artifactId> | |||
| <version>1.41</version> | |||
| <version>1.42</version> | |||
There was a problem hiding this comment.
Bumps maven-site-plugin from 3.6 to 3.7. See jenkinsci/pom#21
batmat
removed
the
on-hold
|
2.119 release is out, un |
oleg-nenashev
approved these changes
May 4, 2018
oleg-nenashev
added
ready-for-merge
|
Thanks a lot Oleg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special old module for doxia seems not needed.
I suspect that it is because since 2012 when it was released, the Markdown
support got done in standard.
As this didn't get any update since 2012, IIUC this was pulling in some very old doxia versions, which was incompatible with maven-fluido-skin which I needed to bump from current 1.3.0 to 1.7 for https://github.com/jenkins-infra/core-taglibs-report-generator to work again.
See jenkins-infra/core-taglibs-report-generator#7 applied in practice.
See JENKINS-50969.
Proposed changelog entries
N/A internal change (
maven-site-pluginonly).Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@daniel-beck