Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade detached plugins to versions with Guava compatibility fixes #5773

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

basil
Copy link
Member

@basil basil commented Oct 2, 2021

To be compatible with recent versions of Guava, Pipeline: API needs jenkinsci/workflow-api-plugin#135 and SCM API needs jenkinsci/scm-api-plugin#85. The former was released in 2.42, and the latter was released in 2.6.5. In preparation for the Guava upgrade in core, this PR bumps the versions of these detached plugins to those mentioned above. Since workflow-api 2.42 depends on workflow-step-api 2.23, we update that as well. Since scm-api 2.6.5 depends on structs 1.23, we update that as well.

Proposed changelog entries

  • Update bundled versions of Pipeline: API, Pipeline: Step API, SCM API, and Structs plugins.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@MarkEWaite and @dheerajodha include links to Pipeline: API, Pipeline: Step API, SCM API, and Structs plugins in the references section of the changelog

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted dependencies Pull requests that update a dependency file labels Oct 2, 2021
@basil basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Oct 2, 2021
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 3, 2021
@timja
Copy link
Member

timja commented Oct 3, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@oleg-nenashev oleg-nenashev merged commit def5155 into jenkinsci:master Oct 4, 2021
@oleg-nenashev
Copy link
Member

@basil would it help to have a Global project for Guava updates?

@basil basil deleted the guava-detached branch October 4, 2021 17:22
@basil
Copy link
Member Author

basil commented Oct 4, 2021

@basil would it help to have a Global project for Guava updates?

I generally prefer to use Jira rather than GitHub issues or projects, and I have been using Jira successfully for this project up until now, so I don't see a pressing need for a global project. That having been said, I don't feel strongly about it, and if someone wants to create a global project to group Guava-related PRs together that is fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants