Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sonar analysis because it's always failing as false negative #478

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 23, 2022

this is always failing and marking PR checks as failed whereas it's not.
As nobody reads the reports neither fix what is reported, maybe we can consider this as noise.

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

this is always failing and marking PR checks as failed whereas it's not.
As nobody reads the reports neither `fix` what is reported, maybe we can consider this as noise.
@rantoniuk
Copy link
Contributor

This is always failing as I have just introduced it and I need to fix an issue with the unsupported GH action workflow.
I'll update the workflow action to not fail the build though.

@rantoniuk rantoniuk self-assigned this Aug 23, 2022
@olamy
Copy link
Member Author

olamy commented Aug 23, 2022

This is always failing as I have just introduced it and I need to fix an issue with the unsupported GH action workflow. I'll update the workflow action to not fail the build though.

why have you introduced this without a PR?
at least to ask POV from other contributing here?
Perso I feel it's like a new toy trying but nobody will read the report and fix the "issues" which can be a lot false positive....

@olamy olamy assigned olamy and unassigned rantoniuk Aug 23, 2022
@olamy
Copy link
Member Author

olamy commented Aug 23, 2022

@rantoniuk I will merge this to fix the checks.
PLEASE PROVIDE SUCH VIA A PR!!
because you pushed something broken directly to master!!! and leave it as is broken for weeks!!

@olamy olamy merged commit 326de71 into master Aug 23, 2022
@olamy olamy deleted the remove-failing-sonar branch August 23, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants